From: Alexander Adolf <alexander.adolf@condition-alpha.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show
Date: Wed, 06 Apr 2022 22:23:49 +0200 [thread overview]
Message-ID: <90f50b09c047913abad928c461b08412@condition-alpha.com> (raw)
In-Reply-To: <87pmm43nig.fsf@tethera.net>
Hello David,
David Bremner <david@tethera.net> writes:
> [...]
> Thanks for sending that. It's a bit tricky to review SMIME stuff as I
> believe none of the devs is really using SMIME regularly. One thing that
> would help is adding one or more tests. Basically the test suite already
> has a SMIME certificate, so if you can encrypt a message to that cert
> (or use one of the existing ones), you can test that the message
> displays OK in Emacs. The corresponding test set would probably be
> T450-emacs-show, but it might be easier to add to T355-smime. Eventually
> we'll also need a short update to doc/notmuch-emacs.rst.
> [...]
Apologies for the delay in getting back to you, and thanks for the
pointers.
I have had a look to both files, and I _think_ T450-emacs-show would
seem more appropriate. It seems that T355-smime is more aimed at the
pure mechanics of en-/decryption, and the handling of that in
libnotmuch. Neither of these have been a problem for me.
Further looking at T450-emacs-show, I find that it uses a somewhat
extensive framework to implement its test cases. Any chances of giving
me a fast start with this, or will it be down to "use the source, Luke"?
Many thanks in advance and looking forward to your thoughts,
--alexander
next prev parent reply other threads:[~2022-04-06 20:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 13:43 [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show Alexander Adolf
2022-03-29 13:18 ` David Bremner
2022-04-06 20:23 ` Alexander Adolf [this message]
2022-04-07 12:25 ` David Bremner
2022-04-07 13:02 ` Alexander Adolf
2022-04-07 14:01 ` David Bremner
2022-04-11 15:35 ` Alexander Adolf
2022-04-11 23:36 ` David Bremner
2022-04-12 16:21 ` Alexander Adolf
2022-04-13 23:56 ` David Bremner
2022-05-11 15:41 ` Alexander Adolf
2022-05-16 16:17 ` Alexander Adolf
2022-05-18 10:29 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90f50b09c047913abad928c461b08412@condition-alpha.com \
--to=alexander.adolf@condition-alpha.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).