From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YI45AN72TWJe2wAAgWs5BA (envelope-from ) for ; Wed, 06 Apr 2022 22:23:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CGNRNN32TWJ0GQEAG6o9tA (envelope-from ) for ; Wed, 06 Apr 2022 22:23:57 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0A2AD2C873 for ; Wed, 6 Apr 2022 22:23:57 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5D05A5F6EC; Wed, 6 Apr 2022 20:23:54 +0000 (UTC) Received: from smtprelay07.ispgateway.de (smtprelay07.ispgateway.de [134.119.228.105]) by mail.notmuchmail.org (Postfix) with ESMTPS id A01E75E017 for ; Wed, 6 Apr 2022 20:23:51 +0000 (UTC) Received: from [46.244.214.245] (helo=condition-alpha.com) by smtprelay07.ispgateway.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ncCC2-0003DZ-LY; Wed, 06 Apr 2022 22:23:54 +0200 Message-Id: <90f50b09c047913abad928c461b08412@condition-alpha.com> From: Alexander Adolf To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show In-Reply-To: <87pmm43nig.fsf@tethera.net> References: <9cc1c3dc135b5126efd210ee97b88d6b@condition-alpha.com> <87pmm43nig.fsf@tethera.net> Date: Wed, 06 Apr 2022 22:23:49 +0200 MIME-Version: 1.0 X-Df-Sender: YWxleGFuZGVyLmFkb2xmQGNvbmRpdGlvbi1hbHBoYS5jb20= Message-ID-Hash: AALVXONOSWAV3QJEBWDSX64JGSYXNXJW X-Message-ID-Hash: AALVXONOSWAV3QJEBWDSX64JGSYXNXJW X-MailFrom: alexander.adolf@condition-alpha.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649276637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=aQSv5wPDT1zDOq9q7RAP0iuL4/QjTN6XgOAw4leThjU=; b=SHWmDchhk+6mzh4NjRfnCSOHNc57DzB1st2CsPSB9ls7KHOVf0ZOIyiwWIAtG4L88E3syq JWtoglOM4zRJEs35sWPqQJMKP+4aeO3LaovNXRsXzNTTNAXKYlRetIeWXCALkSecBdm5jc muddlOvujL3CuS5A/cZ7HnbQ1JDOc5AeSDqVFFsDIplrK1fSvygrrWNM1RmUaQo5PUwnhp MYC2d/0KAIqfOnijRTyKGJ9h9RcYWDo8d2vjQKcPyrz8pbopnffCiQCenm1m2tA1dC8Q/D oNMJXmaXjB44RZjH7yAUK4o1yJUCK3iWl9OdBg5SQMRrND4cJMwzTIEjBY55fA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649276637; a=rsa-sha256; cv=none; b=Kp9P74qUa0in1N/d6P/1UWe98juospaRUKuModYA1s11i8MIUGqCC9t6B451AVGR0dCAaT L89kQK/nRicxW7vTRhyIYq4o9KrFLEZvDcqMacoWxeiWHedJm3B+S2uQPVfa7Wj2ljzd15 pXm4BbL+RE26XpbeBEfpIha9MgnIbZizdk7xtf7kwhcaEHipFy2Bnmwq4drBcKAeif06uR icwthtXHMuuMoVCDy71MujC7WnJA/X0qTH/dLnX90Ecm2/MH4sBma+pgRvYF97UQRb+BkX zhYgrfKGZV8aoZHEwwND8vQ33Z/T4zgrcRJ9Ln53m6mX71y4Fk44EraZB3dhIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.19 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 0A2AD2C873 X-Spam-Score: -0.19 X-Migadu-Scanner: scn1.migadu.com X-TUID: niVRMy4WzjSg Hello David, David Bremner writes: > [...] > Thanks for sending that. It's a bit tricky to review SMIME stuff as I > believe none of the devs is really using SMIME regularly. One thing that > would help is adding one or more tests. Basically the test suite already > has a SMIME certificate, so if you can encrypt a message to that cert > (or use one of the existing ones), you can test that the message > displays OK in Emacs. The corresponding test set would probably be > T450-emacs-show, but it might be easier to add to T355-smime. Eventually > we'll also need a short update to doc/notmuch-emacs.rst. > [...] Apologies for the delay in getting back to you, and thanks for the pointers. I have had a look to both files, and I _think_ T450-emacs-show would seem more appropriate. It seems that T355-smime is more aimed at the pure mechanics of en-/decryption, and the handling of that in libnotmuch. Neither of these have been a problem for me. Further looking at T450-emacs-show, I find that it uses a somewhat extensive framework to implement its test cases. Any chances of giving me a fast start with this, or will it be down to "use the source, Luke"? Many thanks in advance and looking forward to your thoughts, --alexander