From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH v3] build: write VERSION file containing $(VERSION) string
Date: Mon, 27 Jan 2014 21:56:21 -0400 [thread overview]
Message-ID: <87zjmgkgxm.fsf@zancas.localnet> (raw)
In-Reply-To: <1390859290-10112-1-git-send-email-tomi.ollila@iki.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> +VERSION:=$(shell gv=`exec git describe --match '[0-9.]*'|sed -e s/_/~/ -e s/-/+/ -e s/-/~/`; test -f VERSION || touch VERSION; read fv < VERSION; test x"$$fv" = x"$$gv" || echo "$$gv" > VERSION; echo "$$gv")
does this need to be one line long? It's a bit scary.
> +# this file may already have been updated.
> +VERSION: version
> + echo $(VERSION) > version
I'd prefer the build process does not change any version controlled
file. It should be source, or generated, but not both. did you mean to
write to VERSION here?
d
next prev parent reply other threads:[~2014-01-28 1:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 22:43 [PATCH 1/1] build: write VERSION file containing $(VERSION) string Tomi Ollila
2014-01-26 19:55 ` Mark Walters
2014-01-27 21:43 ` [PATCH v2] " Tomi Ollila
2014-01-27 21:48 ` [PATCH v3] " Tomi Ollila
2014-01-28 1:56 ` David Bremner [this message]
2014-01-28 11:13 ` Tomi Ollila
2014-02-05 22:58 ` [PATCH v4] " Tomi Ollila
2014-02-08 23:56 ` W. Trevor King
2014-02-09 8:26 ` Tomi Ollila
2014-02-09 14:38 ` [PATCH v5] build: write version.stamp " Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjmgkgxm.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).