From: "W. Trevor King" <wking@tremily.us>
To: Tomi Ollila <tomi.ollila@iki.fi>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v4] build: write VERSION file containing $(VERSION) string
Date: Sat, 8 Feb 2014 15:56:23 -0800 [thread overview]
Message-ID: <20140208235623.GF17142@odin.tremily.us> (raw)
In-Reply-To: <1391641113-4669-1-git-send-email-tomi.ollila@iki.fi>
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
On Thu, Feb 06, 2014 at 12:58:33AM +0200, Tomi Ollila wrote:
> -VERSION:=$(shell git describe --match '[0-9.]*'|sed -e s/_/~/ -e s/-/+/ -e s/-/~/)
> +# Also write VERSION file in case its contents differ from $(VERSION)
> +VERSION:=$(shell\
> + gv=`git describe --match '[0-9.]*'|sed -e s/_/~/ -e s/-/+/ -e s/-/~/`;\
Ew, backticks ;). What about handling more of the logic in Make:
VERSION := $(shell git describe …)
FILE_VERSION := $(shell test -f VERSION || touch VERSION; cat VERSION)
ifneq ($(FILE_VERSION), $(VERSION))
$(shell echo "$(VERSION)" > VERSION)
endif
> +# Depend (also) on 'version' file. In case of ifeq ($(IS_GIT),yes)
> +# this file may already have been updated.
> +VERSION: version
> + echo $(VERSION) > $@
Do we care about case-insensitive filesystems where VERSION will
collide with version?
> -CLEAN := $(CLEAN) notmuch notmuch-shared $(notmuch_client_modules) notmuch.elc
> +CLEAN := $(CLEAN) VERSION notmuch notmuch-shared $(notmuch_client_modules)
Where did notmuch.elc go?
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-08 23:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 22:43 [PATCH 1/1] build: write VERSION file containing $(VERSION) string Tomi Ollila
2014-01-26 19:55 ` Mark Walters
2014-01-27 21:43 ` [PATCH v2] " Tomi Ollila
2014-01-27 21:48 ` [PATCH v3] " Tomi Ollila
2014-01-28 1:56 ` David Bremner
2014-01-28 11:13 ` Tomi Ollila
2014-02-05 22:58 ` [PATCH v4] " Tomi Ollila
2014-02-08 23:56 ` W. Trevor King [this message]
2014-02-09 8:26 ` Tomi Ollila
2014-02-09 14:38 ` [PATCH v5] build: write version.stamp " Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140208235623.GF17142@odin.tremily.us \
--to=wking@tremily.us \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).