[PATCH] test/emacs: mark one test as fixed in newer emacs.

[PATCH] test/emacs: mark one test as fixed in newer emacs.

[David Bremner]

The remaining problem in this test is fixed upstream in Emacs
28. While most people are using earlier versions of emacs, the test
still provides some documentation of a known bug.
---
 test/T450-emacs-show.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh
index 4b5f5fde..2a192ed0 100755
--- a/test/T450-emacs-show.sh
+++ b/test/T450-emacs-show.sh
@@ -220,7 +220,9 @@ test_emacs '(notmuch-show "id:basic-encrypted@crypto.notmuchmail.org")
 test_expect_equal_file $EXPECTED/notmuch-show-decrypted-message OUTPUT
 
 test_begin_subtest "show encrypted rfc822 message"
-test_subtest_known_broken
+if ${TEST_EMACS} --quick --batch --eval '(if (version< emacs-version "28") (kill-emacs 0) (kill-emacs 1)))'; then
+    test_subtest_known_broken
+fi
 test_emacs '(notmuch-show "id:encrypted-rfc822-attachment@crypto.notmuchmail.org")
             (test-visible-output)'
 test_expect_code 1 'fgrep "!!!" OUTPUT'
-- 
2.33.0

Re: [PATCH] test/emacs: mark one test as fixed in newer emacs.

[Tomi Ollila]

On Sun, Dec 05 2021, David Bremner wrote:

> The remaining problem in this test is fixed upstream in Emacs
> 28. While most people are using earlier versions of emacs, the test
> still provides some documentation of a known bug.
> ---
>  test/T450-emacs-show.sh | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh
> index 4b5f5fde..2a192ed0 100755
> --- a/test/T450-emacs-show.sh
> +++ b/test/T450-emacs-show.sh
> @@ -220,7 +220,9 @@ test_emacs '(notmuch-show "id:basic-encrypted@crypto.notmuchmail.org")
>  test_expect_equal_file $EXPECTED/notmuch-show-decrypted-message OUTPUT
>  
>  test_begin_subtest "show encrypted rfc822 message"
> -test_subtest_known_broken
> +if ${TEST_EMACS} --quick --batch --eval '(if (version< emacs-version
>  "28") (kill-emacs 0) (kill-emacs 1)))'; then

looks good but perhaps "drier" version:

    (kill-emacs (if (version< emacs-version "28") 0 1))

Tomi

> +    test_subtest_known_broken
> +fi
>  test_emacs '(notmuch-show "id:encrypted-rfc822-attachment@crypto.notmuchmail.org")
>              (test-visible-output)'
>  test_expect_code 1 'fgrep "!!!" OUTPUT'
> -- 
> 2.33.0

Re: [PATCH] test/emacs: mark one test as fixed in newer emacs.

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Sun, Dec 05 2021, David Bremner wrote:
>
>> The remaining problem in this test is fixed upstream in Emacs
>> 28. While most people are using earlier versions of emacs, the test
>> still provides some documentation of a known bug.
>> ---
>>  test/T450-emacs-show.sh | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh
>> index 4b5f5fde..2a192ed0 100755
>> --- a/test/T450-emacs-show.sh
>> +++ b/test/T450-emacs-show.sh
>> @@ -220,7 +220,9 @@ test_emacs '(notmuch-show "id:basic-encrypted@crypto.notmuchmail.org")
>>  test_expect_equal_file $EXPECTED/notmuch-show-decrypted-message OUTPUT
>>  
>>  test_begin_subtest "show encrypted rfc822 message"
>> -test_subtest_known_broken
>> +if ${TEST_EMACS} --quick --batch --eval '(if (version< emacs-version
>>  "28") (kill-emacs 0) (kill-emacs 1)))'; then
>
> looks good but perhaps "drier" version:
>
>     (kill-emacs (if (version< emacs-version "28") 0 1))

Oops, don't tell my students I missed that ;). Applied your version to
master