From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH] build: drop support for xapian versions less than 1.4
Date: Thu, 02 Apr 2020 07:12:28 -0300 [thread overview]
Message-ID: <87y2re42nn.fsf@tethera.net> (raw)
In-Reply-To: <20200222222955.6795-1-tomi.ollila@iki.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> Xapian 1.4 is over 3 years old now (1.4.0 released 2016-06-24),
> and 1.2 has been deprecated in Notmuch version 0.27 (2018-06-13).
>
> Xapian 1.4 supports compaction, field processors and retry locking;
> conditionals checking compaction and field processors were removed
> but user may want to disable retry locking at configure time so it
> is kept.
Hi Tomi;
I didn't understand why yet, but I'm consistently getting a test failure
with your patch.
T670-duplicate-mid: Testing duplicate message ids
BROKEN First subject preserved in notmuch-show (json)
FAIL Regexp search for second subject
--- T670-duplicate-mid.4.EXPECTED 2020-04-02 10:10:39.461044592 +0000
+++ T670-duplicate-mid.4.OUTPUT 2020-04-02 10:10:39.461044592 +0000
@@ -1,3 +0,0 @@
-MAIL_DIR/copy0
-MAIL_DIR/copy1
-MAIL_DIR/copy2
Does the test pass for you?
David
next prev parent reply other threads:[~2020-04-02 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 22:29 [PATCH] build: drop support for xapian versions less than 1.4 Tomi Ollila
2020-04-02 10:12 ` David Bremner [this message]
2020-04-21 21:07 ` [PATCH v2] " Tomi Ollila
2020-04-24 0:33 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2re42nn.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).