From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 62DF76DE0F50
 for <notmuch@notmuchmail.org>; Thu,  2 Apr 2020 03:12:38 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.068
X-Spam-Level: 
X-Spam-Status: No, score=-0.068 tagged_above=-999 required=5
 tests=[AWL=-0.067, SPF_PASS=-0.001] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 0CoL1kWpTAL7 for <notmuch@notmuchmail.org>;
 Thu,  2 Apr 2020 03:12:35 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id D81EC6DE0F43
 for <notmuch@notmuchmail.org>; Thu,  2 Apr 2020 03:12:35 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.92)
 (envelope-from <david@tethera.net>)
 id 1jJwpq-0005IM-5Q; Thu, 02 Apr 2020 06:12:30 -0400
Received: (nullmailer pid 3797411 invoked by uid 1000);
 Thu, 02 Apr 2020 10:12:28 -0000
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH] build: drop support for xapian versions less than 1.4
In-Reply-To: <20200222222955.6795-1-tomi.ollila@iki.fi>
References: <20200222222955.6795-1-tomi.ollila@iki.fi>
Date: Thu, 02 Apr 2020 07:12:28 -0300
Message-ID: <87y2re42nn.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Apr 2020 10:12:38 -0000

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Xapian 1.4 is over 3 years old now (1.4.0 released 2016-06-24),
> and 1.2 has been deprecated in Notmuch version 0.27 (2018-06-13).
>
> Xapian 1.4 supports compaction, field processors and retry locking;
> conditionals checking compaction and field processors were removed
> but user may want to disable retry locking at configure time so it
> is kept.

Hi Tomi;

I didn't understand why yet, but I'm consistently getting a test failure
with your patch.

T670-duplicate-mid: Testing duplicate message ids
 BROKEN First subject preserved in notmuch-show (json)
 FAIL   Regexp search for second subject
	--- T670-duplicate-mid.4.EXPECTED	2020-04-02 10:10:39.461044592 +0000
	+++ T670-duplicate-mid.4.OUTPUT	2020-04-02 10:10:39.461044592 +0000
	@@ -1,3 +0,0 @@
	-MAIL_DIR/copy0
	-MAIL_DIR/copy1
	-MAIL_DIR/copy2

Does the test pass for you?

David