unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: Memory leak in notmuch_database_destroy()
Date: Mon, 24 Jan 2022 10:58:42 -0400	[thread overview]
Message-ID: <87wnipch99.fsf@tethera.net> (raw)
In-Reply-To: <20220105224538.m36lnjn7rf3ieonc@athena>

Austin Ray <austin@austinray.io> writes:

> Hi,
>
> libnotmuch 5.5.0 (notmuch 0.34.2) leaks memory when opening a database
> with 'notmuch_database_open_with_config()' and cleaning it up with
> 'notmuch_database_destroy()'. I've included a reproducer program (based
> on an existing notmuch test) and ASAN output below.
>
> Replacing 'notmuch_database_destroy()' with 'notmuch_database_close()'
> or omitting the database clean-up entirely resolves all but the first
> ASAN entry. There's no leak if 'notmuch_database_open_with_config()'
> returns an error.
>
> Thanks!
>
> Austin

In id:20220122205416.nbxqdcapjab62iln@athena Austin confirmed these leaks
were fixed as of 2786aa4d548d28579c761e9358d44c84dfb29068

      parent reply	other threads:[~2022-01-24 14:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05 22:45 Austin Ray
2022-01-08 18:28 ` [PATCH 1/2] lib/config: move g_key_File_get_string before continue David Bremner
2022-01-08 18:28   ` [PATCH 2/2] lib/database: delete stemmer on destroy David Bremner
2022-01-24 14:58 ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnipch99.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --subject='Re: Memory leak in notmuch_database_destroy()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	notmuch.git.git (no URL configured)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).