unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Austin Ray <austin@austinray.io>, notmuch@notmuchmail.org
Subject: [PATCH 2/2] lib/database: delete stemmer on destroy
Date: Sat,  8 Jan 2022 14:28:44 -0400	[thread overview]
Message-ID: <20220108182844.3147598-2-david@tethera.net> (raw)
In-Reply-To: <20220108182844.3147598-1-david@tethera.net>

Commit 3202e0d1feba1ab955ba1c07098c00208f8f0ada left the stemmer
object accessible, but did not add de-allocation code to
notmuch_database_destroy. This commit corrects that oversight.
---
 lib/database.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/database.cc b/lib/database.cc
index 6ef56d56..a012ebcf 100644
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -753,6 +753,8 @@ notmuch_database_destroy (notmuch_database_t *notmuch)
     notmuch->date_range_processor = NULL;
     delete notmuch->last_mod_range_processor;
     notmuch->last_mod_range_processor = NULL;
+    delete notmuch->stemmer;
+    notmuch->stemmer = NULL;
 
     talloc_free (notmuch);
 
-- 
2.34.1

  reply	other threads:[~2022-01-08 18:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05 22:45 Memory leak in notmuch_database_destroy() Austin Ray
2022-01-08 18:28 ` [PATCH 1/2] lib/config: move g_key_File_get_string before continue David Bremner
2022-01-08 18:28   ` David Bremner [this message]
2022-01-24 14:58 ` Memory leak in notmuch_database_destroy() David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220108182844.3147598-2-david@tethera.net \
    --to=david@tethera.net \
    --cc=austin@austinray.io \
    --cc=notmuch@notmuchmail.org \
    --subject='Re: [PATCH 2/2] lib/database: delete stemmer on destroy' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	notmuch.git.git (no URL configured)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).