unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] nmweb: Fix spacing around punctuation in headers
@ 2022-10-11  8:19 Jakub Wilk
  2022-10-11 11:20 ` David Bremner
  0 siblings, 1 reply; 4+ messages in thread
From: Jakub Wilk @ 2022-10-11  8:19 UTC (permalink / raw)
  To: notmuch

---
 devel/notmuch-web/nmweb.py            | 2 +-
 devel/notmuch-web/templates/show.html | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

This is completely untested, but hey, what could possibly go wrong?

diff --git a/devel/notmuch-web/nmweb.py b/devel/notmuch-web/nmweb.py
index 7b555c62..b0d4d5cd 100755
--- a/devel/notmuch-web/nmweb.py
+++ b/devel/notmuch-web/nmweb.py
@@ -125,7 +125,7 @@ def mailto_addrs(msg,header_name):
     return ''
 
   frm = email.utils.getaddresses([hdr])
-  return ','.join(['<a href="mailto:%s">%s</a> ' % ((l, p) if p else (l, l)) for (p, l) in frm])
+  return ', '.join(['<a href="mailto:%s">%s</a>' % ((l, p) if p else (l, l)) for (p, l) in frm])
 env.globals['mailto_addrs'] = mailto_addrs
 
 def link_msg(msg):
diff --git a/devel/notmuch-web/templates/show.html b/devel/notmuch-web/templates/show.html
index 98d36acc..690f5464 100644
--- a/devel/notmuch-web/templates/show.html
+++ b/devel/notmuch-web/templates/show.html
@@ -3,10 +3,10 @@
 {% set headers = ['Subject', 'Date'] %}
 {% set addr_headers = ['To', 'Cc', 'From'] %}
 {% for header in headers: %}
-<p><b>{{header}}:</b>{{m.header(header)|e}}</p>
+<p><b>{{header}}:</b> {{m.header(header)|e}}</p>
 {% endfor %}
 {% for header in addr_headers: %}
-<p><b>{{header}}:</b>{{mailto_addrs(m,header)|safe}}</p>
+<p><b>{{header}}:</b> {{mailto_addrs(m,header)|safe}}</p>
 {% endfor %}
 <hr>
 {% for part in format_message(m,mid): %}{{ part|safe }}{% endfor %}
-- 
2.37.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] nmweb: Fix spacing around punctuation in headers
  2022-10-11  8:19 [PATCH] nmweb: Fix spacing around punctuation in headers Jakub Wilk
@ 2022-10-11 11:20 ` David Bremner
  2022-10-11 14:19   ` Jakub Wilk
  0 siblings, 1 reply; 4+ messages in thread
From: David Bremner @ 2022-10-11 11:20 UTC (permalink / raw)
  To: Jakub Wilk, notmuch

Jakub Wilk <jwilk@jwilk.net> writes:

> ---
>  devel/notmuch-web/nmweb.py            | 2 +-
>  devel/notmuch-web/templates/show.html | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> This is completely untested, but hey, what could possibly go wrong?
>

I've yolo-ed this into production on nmbug.notmuchmail.org. Maybe you
can poke at it and see if it looks like you expect.

d

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nmweb: Fix spacing around punctuation in headers
  2022-10-11 11:20 ` David Bremner
@ 2022-10-11 14:19   ` Jakub Wilk
  2022-10-14  9:56     ` David Bremner
  0 siblings, 1 reply; 4+ messages in thread
From: Jakub Wilk @ 2022-10-11 14:19 UTC (permalink / raw)
  To: notmuch

* David Bremner <david@tethera.net>, 2022-10-11 08:20:
>>This is completely untested, but hey, what could possibly go wrong?
>
>I've yolo-ed this into production on nmbug.notmuchmail.org. Maybe you 
>can poke at it and see if it looks like you expect.

Looks good. Thanks!

-- 
Jakub Wilk

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nmweb: Fix spacing around punctuation in headers
  2022-10-11 14:19   ` Jakub Wilk
@ 2022-10-14  9:56     ` David Bremner
  0 siblings, 0 replies; 4+ messages in thread
From: David Bremner @ 2022-10-14  9:56 UTC (permalink / raw)
  To: Jakub Wilk, notmuch

Jakub Wilk <jwilk@jwilk.net> writes:

> * David Bremner <david@tethera.net>, 2022-10-11 08:20:
>>>This is completely untested, but hey, what could possibly go wrong?
>>
>>I've yolo-ed this into production on nmbug.notmuchmail.org. Maybe you 
>>can poke at it and see if it looks like you expect.
>
> Looks good. Thanks!
>

applied to master.

d

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-10-14  9:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-11  8:19 [PATCH] nmweb: Fix spacing around punctuation in headers Jakub Wilk
2022-10-11 11:20 ` David Bremner
2022-10-11 14:19   ` Jakub Wilk
2022-10-14  9:56     ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).