From: Jani Nikula <jani@nikula.org>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init()
Date: Wed, 11 Sep 2013 20:40:40 +0300 [thread overview]
Message-ID: <87vc27p887.fsf@nikula.org> (raw)
In-Reply-To: <8738pcjet4.fsf@awakening.csail.mit.edu>
On Wed, 11 Sep 2013, Austin Clements <amdragon@MIT.EDU> wrote:
> LGTM in principle, though I'd like to see a test of some of the
> malformed RFC 2047 that this lets us decode. Is there a summary
> somewhere of exactly what these workarounds enable?
Not that I know of; looking into gmime source it's mostly about encoded
words without surrounding space, or space within encoded words.
v2 now has known broken tests for known broken encodings...
> This isn't directly related to this patch, but is there a reason we
> g_mime_init in so many different places? Both the CLI and
> notmuch_database_open I can understand because the CLI also uses GMime
> and should be sure it's initialized. Maaaybe
> notmuch_message_file_get_header because notmuch_message_file
> theoretically independent of the database, even though I don't think
> it's possible to call into it without first calling
> notmuch_database_open. But _notmuch_message_index_file?
I noted the same, but decided it's another patch, another time.
BR,
Jani.
prev parent reply other threads:[~2013-09-11 17:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 18:51 [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init() Jani Nikula
2013-09-10 19:31 ` Daniel Kahn Gillmor
2013-09-10 22:35 ` Austin Clements
2013-09-10 22:50 ` [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init() a test Daniel Kahn Gillmor
2013-09-11 1:51 ` Austin Clements
2013-09-11 18:21 ` Jani Nikula
2013-09-11 2:02 ` [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init() Austin Clements
2013-09-11 17:36 ` [PATCH v2 1/2] test: add known broken tests for known broken RFC 2047 encodings Jani Nikula
2013-09-11 17:36 ` [PATCH v2 2/2] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init() Jani Nikula
2013-09-11 18:37 ` [PATCH v2 1/2] test: add known broken tests for known broken RFC 2047 encodings Austin Clements
2013-09-11 19:57 ` Tomi Ollila
2013-09-14 17:21 ` David Bremner
2013-09-11 17:40 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc27p887.fsf@nikula.org \
--to=jani@nikula.org \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).