Re: [PATCH 2/3] database: add n_d_index_file (deprecates n_d_add_message)

[David Bremner <david@tethera.net>]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
> index b187a80f..f6a497b5 100644
> --- a/lib/notmuch-private.h
> +++ b/lib/notmuch-private.h
> @@ -632,6 +632,7 @@ _notmuch_thread_create (void *ctx,
>  			notmuch_exclude_t omit_exclude,
>  			notmuch_sort_t sort);
>  
> +
>  NOTMUCH_END_DECLS

mysterious extra whitespace

>  
>  #ifdef __cplusplus
> diff --git a/lib/notmuch.h b/lib/notmuch.h
> index 02586a91..ed405dc5 100644
> --- a/lib/notmuch.h
> +++ b/lib/notmuch.h
> @@ -237,7 +237,7 @@ typedef struct _notmuch_param notmuch_param_t;
>   * The database will not yet have any data in it
>   * (notmuch_database_create itself is a very cheap function). Messages
>   * contained within 'path' can be added to the database by calling
> - * notmuch_database_add_message.
> + * notmuch_database_index_file.
>   *
>   * In case of any failure, this function returns an error status and
>   * sets *database to NULL (after printing an error message on stderr).
> @@ -561,6 +561,10 @@ notmuch_database_get_directory (notmuch_database_t *database,
>   * database, rather than creating a new message, this adds the search
>   * terms from the identified file to the existing message's index, and
>   * adds 'filename' to the list of filenames known for the message.
> + * 
> + * 'indexopts' can be NULL (meaning, use the indexing defaults from
> + * the database), or can be an explicit choice of indexing options
> + * that should govern the indexing of this specific 'filename'.

Ideally this should have an @since line