From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 1E3F96DE0119 for ; Thu, 17 Aug 2017 04:31:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dspr1ZGs5K77 for ; Thu, 17 Aug 2017 04:31:53 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 588786DE010F for ; Thu, 17 Aug 2017 04:31:53 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1diIyI-000057-FI; Thu, 17 Aug 2017 07:28:18 -0400 Received: (nullmailer pid 23452 invoked by uid 1000); Thu, 17 Aug 2017 11:31:48 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH 2/3] database: add n_d_index_file (deprecates n_d_add_message) In-Reply-To: <20170809054731.23890-2-dkg@fifthhorseman.net> References: <20170809054731.23890-1-dkg@fifthhorseman.net> <20170809054731.23890-2-dkg@fifthhorseman.net> Date: Thu, 17 Aug 2017 08:31:48 -0300 Message-ID: <87valmh1ln.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Aug 2017 11:31:54 -0000 Daniel Kahn Gillmor writes: > diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h > index b187a80f..f6a497b5 100644 > --- a/lib/notmuch-private.h > +++ b/lib/notmuch-private.h > @@ -632,6 +632,7 @@ _notmuch_thread_create (void *ctx, > notmuch_exclude_t omit_exclude, > notmuch_sort_t sort); > > + > NOTMUCH_END_DECLS mysterious extra whitespace > > #ifdef __cplusplus > diff --git a/lib/notmuch.h b/lib/notmuch.h > index 02586a91..ed405dc5 100644 > --- a/lib/notmuch.h > +++ b/lib/notmuch.h > @@ -237,7 +237,7 @@ typedef struct _notmuch_param notmuch_param_t; > * The database will not yet have any data in it > * (notmuch_database_create itself is a very cheap function). Messages > * contained within 'path' can be added to the database by calling > - * notmuch_database_add_message. > + * notmuch_database_index_file. > * > * In case of any failure, this function returns an error status and > * sets *database to NULL (after printing an error message on stderr). > @@ -561,6 +561,10 @@ notmuch_database_get_directory (notmuch_database_t *database, > * database, rather than creating a new message, this adds the search > * terms from the identified file to the existing message's index, and > * adds 'filename' to the list of filenames known for the message. > + * > + * 'indexopts' can be NULL (meaning, use the indexing defaults from > + * the database), or can be an explicit choice of indexing options > + * that should govern the indexing of this specific 'filename'. Ideally this should have an @since line