From: David Bremner <david@tethera.net>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
"Tomi Ollila" <tomi.ollila@iki.fi>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] configure: detect version by compiler for build
Date: Tue, 28 Jul 2020 08:25:00 -0300 [thread overview]
Message-ID: <87v9i7rier.fsf@tethera.net> (raw)
In-Reply-To: <20200728001831.GB7409@danh.dev>
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
>
> Other compile and try run linked with libraries in (autotools') host
> architecture.
>
> Linking with build's libraries doesn't make sense, hence I ignored it.
> And patched downstream.
>
> I don't mind dropping this change and carry it downstream.
>
I'm afraid I don't understand the reference to autotools here. Are you
embedding the build of notmuch in some packaging system that thinks
everything is autotools? I agree with Tomi that changing this one
relatively minor use of CC in isolation does not make sense. I'm not
opposed to upstreaming packaging inspired changes, but generally I would
like to see how they help more than just one packager.
\r
next prev parent reply other threads:[~2020-07-28 11:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 15:41 [PATCH] configure: detect version by compiler for build Đoàn Trần Công Danh
2020-07-27 15:41 ` [PATCH] configure: account for various name of pytest-3 Đoàn Trần Công Danh
2020-07-27 17:37 ` Tomi Ollila
2020-07-28 0:28 ` [PATCH v2] configure: check for pytest with python -m pytest Đoàn Trần Công Danh
2020-07-27 15:41 ` [PATCH] configure: drop check for default xapian backend Đoàn Trần Công Danh
2020-07-28 11:17 ` David Bremner
2020-07-28 13:36 ` Đoàn Trần Công Danh
2020-07-30 0:05 ` David Bremner
2020-07-31 13:49 ` Đoàn Trần Công Danh
2020-07-31 14:41 ` David Bremner
2020-07-27 15:41 ` [PATCH] T355: specify hash algorithm explicitly Đoàn Trần Công Danh
2020-07-27 17:00 ` Đoàn Trần Công Danh
2020-07-27 17:40 ` Tomi Ollila
2020-07-27 23:42 ` Đoàn Trần Công Danh
2020-07-27 17:31 ` [PATCH] configure: detect version by compiler for build Tomi Ollila
2020-07-28 0:18 ` Đoàn Trần Công Danh
2020-07-28 11:25 ` David Bremner [this message]
2020-07-28 13:43 ` Đoàn Trần Công Danh
2020-08-03 15:40 ` [PATCH v2] configure: check for pytest with python -m pytest Đoàn Trần Công Danh
2020-08-07 17:12 ` Tomi Ollila
2020-08-08 19:14 ` David Bremner
2020-08-03 15:40 ` [PATCH v2] configure: drop check for default xapian backend Đoàn Trần Công Danh
2020-08-03 15:40 ` [PATCH v2] T355: specify hash algorithm explicitly Đoàn Trần Công Danh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9i7rier.fsf@tethera.net \
--to=david@tethera.net \
--cc=congdanhqx@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).