From: David Bremner <david@tethera.net>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] configure: drop check for default xapian backend
Date: Wed, 29 Jul 2020 21:05:37 -0300 [thread overview]
Message-ID: <87d04deujy.fsf@tethera.net> (raw)
In-Reply-To: <20200728133645.GB24134@danh.dev>
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
> On 2020-07-28 08:17:49-0300, David Bremner <david@tethera.net> wrote:
>> Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
>>
>> > Starting from xapian 1.3.5, xapian switched default backend to glass.
>> >
>> > From 00cdfe10 (build: drop support for xapian versions less than 1.4,
>> > 2020-04-22), we only support xapian 1.4.0+. Effectively, we don't need
>> > to check for default xapian backend anymore.
>> >
>> > Let's drop it.
>>
>> This is not wrong, but I wonder if we will need to put it all back in a
>> slightly modified form when Xapian 1.6 releases with a new default
>> backend. I guess we can start by reverting this patch if that happens?
>
> I have a quick skim over current codebase,
> if I have not missed anything,
> this check is only applicable for testing.
>
> I think a future-proof move would be moving
> this check to a runtime check in "make test".
>
> What do you think?
I sent a couple of patches removing all use from the test suite, so you
could respin your series with just the configure modifications. Or feel
free to incorporate my patches into your series, whatever is most
convenient. It's quite possible there are shell script related
improvements for my patches, so you might want to wait a couple of days.
d
next prev parent reply other threads:[~2020-07-30 0:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 15:41 [PATCH] configure: detect version by compiler for build Đoàn Trần Công Danh
2020-07-27 15:41 ` [PATCH] configure: account for various name of pytest-3 Đoàn Trần Công Danh
2020-07-27 17:37 ` Tomi Ollila
2020-07-28 0:28 ` [PATCH v2] configure: check for pytest with python -m pytest Đoàn Trần Công Danh
2020-07-27 15:41 ` [PATCH] configure: drop check for default xapian backend Đoàn Trần Công Danh
2020-07-28 11:17 ` David Bremner
2020-07-28 13:36 ` Đoàn Trần Công Danh
2020-07-30 0:05 ` David Bremner [this message]
2020-07-31 13:49 ` Đoàn Trần Công Danh
2020-07-31 14:41 ` David Bremner
2020-07-27 15:41 ` [PATCH] T355: specify hash algorithm explicitly Đoàn Trần Công Danh
2020-07-27 17:00 ` Đoàn Trần Công Danh
2020-07-27 17:40 ` Tomi Ollila
2020-07-27 23:42 ` Đoàn Trần Công Danh
2020-07-27 17:31 ` [PATCH] configure: detect version by compiler for build Tomi Ollila
2020-07-28 0:18 ` Đoàn Trần Công Danh
2020-07-28 11:25 ` David Bremner
2020-07-28 13:43 ` Đoàn Trần Công Danh
2020-08-03 15:40 ` [PATCH v2] configure: check for pytest with python -m pytest Đoàn Trần Công Danh
2020-08-07 17:12 ` Tomi Ollila
2020-08-08 19:14 ` David Bremner
2020-08-03 15:40 ` [PATCH v2] configure: drop check for default xapian backend Đoàn Trần Công Danh
2020-08-03 15:40 ` [PATCH v2] T355: specify hash algorithm explicitly Đoàn Trần Công Danh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d04deujy.fsf@tethera.net \
--to=david@tethera.net \
--cc=congdanhqx@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).