From: Damien Cassou <damien@cassou.me>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] Fix notmuch-mua.el notmuch-mua-mail
Date: Wed, 01 Jun 2022 21:57:26 +0200 [thread overview]
Message-ID: <87v8tk17ix.fsf@cassou.me> (raw)
In-Reply-To: <875ylk1zo9.fsf@tethera.net>
Hi David,
David Bremner <david@tethera.net> writes:
> If possible, please use git-send-email, as it makes applying the patches
> easier.
I've sent a new version in <20220601195048.166397-1-damien@cassou.me>. I
hope I followed all recommendations. If I didn't, please tell me so I
can do better next time.
Can you please explain me what in git-send-email makes it easier to
apply the patches? I'm also interested in your process to apply patches
from your mua (notmuch in Emacs hopefully) to your git repository.
> Our conventions for commit messages are different than emacs [1], we
> don't list filenames in the commit message but we do usually list the
> "subsystem" in the subject [2]
I'm sorry I completely forgot to have a look at the conventions before
sending.
> I think the cursor positioning behaviour should be documented in the
> function docstring.
done
> [1]: It might be a personal issue, but the emacs commit message style
> really annoys me.
I also don't like it. I think it focuses too much on what has changed
(something that could be inferred from the patch with a little tooling)
instead of why the code has changed this way (something only the author
can tell).
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
next prev parent reply other threads:[~2022-06-01 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 7:08 [PATCH] Fix notmuch-mua.el notmuch-mua-mail Damien Cassou
2022-05-23 6:21 ` Damien Cassou
2022-06-01 9:49 ` David Bremner
2022-06-01 19:57 ` Damien Cassou [this message]
2022-06-02 11:12 ` David Bremner
2022-06-02 12:53 ` Damien Cassou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8tk17ix.fsf@cassou.me \
--to=damien@cassou.me \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).