From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aLVTKq3El2IpkQAAbAwnHQ (envelope-from ) for ; Wed, 01 Jun 2022 21:57:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0AsnKq3El2JhYgAAauVa8A (envelope-from ) for ; Wed, 01 Jun 2022 21:57:33 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2B23643EF9 for ; Wed, 1 Jun 2022 21:57:33 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 8B9E35F7B5; Wed, 1 Jun 2022 19:57:30 +0000 (UTC) Received: from mail.choca.pics (mail.choca.pics [80.67.172.235]) by mail.notmuchmail.org (Postfix) with ESMTPS id 84DD35F7B2 for ; Wed, 1 Jun 2022 19:57:28 +0000 (UTC) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id F33DB18193F59; Wed, 1 Jun 2022 21:57:27 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id hLzGP57IKV9v; Wed, 1 Jun 2022 21:57:27 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 5023718193F5B; Wed, 1 Jun 2022 21:57:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id oy8g5w2ou6pR; Wed, 1 Jun 2022 21:57:27 +0200 (CEST) Received: from localhost (153.226.95.79.rev.sfr.net [79.95.226.153]) by mail.choca.pics (Postfix) with ESMTPSA id F288318193F59; Wed, 1 Jun 2022 21:57:26 +0200 (CEST) From: Damien Cassou To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] Fix notmuch-mua.el notmuch-mua-mail In-Reply-To: <875ylk1zo9.fsf@tethera.net> References: <87fsl22geh.fsf@cassou.me> <87zgj8zs3k.fsf@cassou.me> <875ylk1zo9.fsf@tethera.net> Date: Wed, 01 Jun 2022 21:57:26 +0200 Message-ID: <87v8tk17ix.fsf@cassou.me> MIME-Version: 1.0 Message-ID-Hash: XDS437PKMJCCHDRL73QRHTK33CSFGBJK X-Message-ID-Hash: XDS437PKMJCCHDRL73QRHTK33CSFGBJK X-MailFrom: damien@cassou.me X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0 X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654113453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=qhwWsmYnjb0TJlLmeFfGW1K+Bcvt+/xwLCu+/IVmJpY=; b=Ut9l9gULwLHEoHBCGltNdgtHDJy1MPACZAwGw0nOo8VeMmMDj/NlHaVYyC/zP01iMLAzA6 A8Qzg0FDViAX1SDKL+MrVz1rTV44aB8MjZ8RSDf1lYkt+kkN6vIWzLKFfUHN9N64GFDQGv gCM1pb57ty+lpSzA+f/n0hZf1Es3Gnjm5z1el5H2cAVxXV0vfD5PfryU69iKaELXlHyo0N VOYbfqoKooqTI80sRon8ihJL4lafW5fVkB8ammtO9JJqi9eFqMQeF9GNspbMADl4CI3BHB M6I/T+nIx2rzrCh9zqjO5+Q9tgaJsK+iHZx5Oq6HfBDZeuqk9lnwYZJWn+dnmA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654113453; a=rsa-sha256; cv=none; b=d6er2CY4nGIl4TjlVJE7b4oJ6gYTpVdxPFaKhkujpAQCN9eT4CKr32IulOcJmvQPEtGXf6 TtZRuw79l05oDgqFWqma756lP/k5p8gYsKfheQNTjvMjyo1fSBiPcUj8ocMtKIjl/Re2BH 8Tts5J7ZCQj5Xyb37SfHf9gut4ro+YYtA6rgSq1HXVQAf5FNyJ5uqCPaS1gLjiNBEmKAUI Bh4YFPSD0jNcZGrfovTUJTKs0qR8PBE9K6USWZbhlGEW5SnQEDSglqN+F4T/CpBK+sIymC o4pmD89O3IZRqHjcfC6H6oXMGqQhDmkW3r7iNnA+nErMAi80b1vesucNNC7XLg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.06 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 2B23643EF9 X-Spam-Score: -2.06 X-Migadu-Scanner: scn1.migadu.com X-TUID: 0xJlzoCDHwJl Hi David, David Bremner writes: > If possible, please use git-send-email, as it makes applying the patches > easier. I've sent a new version in <20220601195048.166397-1-damien@cassou.me>. I hope I followed all recommendations. If I didn't, please tell me so I can do better next time. Can you please explain me what in git-send-email makes it easier to apply the patches? I'm also interested in your process to apply patches from your mua (notmuch in Emacs hopefully) to your git repository. > Our conventions for commit messages are different than emacs [1], we > don't list filenames in the commit message but we do usually list the > "subsystem" in the subject [2] I'm sorry I completely forgot to have a look at the conventions before sending. > I think the cursor positioning behaviour should be documented in the > function docstring. done > [1]: It might be a personal issue, but the emacs commit message style > really annoys me. I also don't like it. I think it focuses too much on what has changed (something that could be inferred from the patch with a little tooling) instead of why the code has changed this way (something only the author can tell). -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill