unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] test: remove redundant 'file' command from gdb scripts.
@ 2015-05-31 16:59 David Bremner
  2015-06-01  9:02 ` Tomi Ollila
  2015-06-02  2:58 ` David Bremner
  0 siblings, 2 replies; 3+ messages in thread
From: David Bremner @ 2015-05-31 16:59 UTC (permalink / raw)
  To: notmuch

Quoting Debian bug 787341

   It failed to build on arm64: the last ten tests in T070-insert
   failed.

   What's happening here is that GDB is segfaulting in response to
   the
   "file" command. GDB on arm64 can be a bit buggy.

   However, the "file" command is redundant here as GDB has already
   got
   the file from the --args on the command line.
---
 test/T070-insert.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/test/T070-insert.sh b/test/T070-insert.sh
index 168345c..74f1955 100755
--- a/test/T070-insert.sh
+++ b/test/T070-insert.sh
@@ -191,7 +191,6 @@ for code in OUT_OF_MEMORY XAPIAN_EXCEPTION FILE_NOT_EMAIL \
     READ_ONLY_DATABASE UPGRADE_REQUIRED; do
 gen_insert_msg
 cat <<EOF > index-file-$code.gdb
-file notmuch
 set breakpoint pending on
 break notmuch_database_add_message
 commands
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: remove redundant 'file' command from gdb scripts.
  2015-05-31 16:59 [PATCH] test: remove redundant 'file' command from gdb scripts David Bremner
@ 2015-06-01  9:02 ` Tomi Ollila
  2015-06-02  2:58 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2015-06-01  9:02 UTC (permalink / raw)
  To: David Bremner, notmuch

On Sun, May 31 2015, David Bremner <david@tethera.net> wrote:

> Quoting Debian bug 787341
>
>    It failed to build on arm64: the last ten tests in T070-insert
>    failed.
>
>    What's happening here is that GDB is segfaulting in response to
>    the
>    "file" command. GDB on arm64 can be a bit buggy.
>
>    However, the "file" command is redundant here as GDB has already
>    got
>    the file from the --args on the command line.
> ---

looks trivial enough to me...

>  test/T070-insert.sh | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/test/T070-insert.sh b/test/T070-insert.sh
> index 168345c..74f1955 100755
> --- a/test/T070-insert.sh
> +++ b/test/T070-insert.sh
> @@ -191,7 +191,6 @@ for code in OUT_OF_MEMORY XAPIAN_EXCEPTION FILE_NOT_EMAIL \
>      READ_ONLY_DATABASE UPGRADE_REQUIRED; do
>  gen_insert_msg
>  cat <<EOF > index-file-$code.gdb
> -file notmuch
>  set breakpoint pending on
>  break notmuch_database_add_message
>  commands
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: remove redundant 'file' command from gdb scripts.
  2015-05-31 16:59 [PATCH] test: remove redundant 'file' command from gdb scripts David Bremner
  2015-06-01  9:02 ` Tomi Ollila
@ 2015-06-02  2:58 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2015-06-02  2:58 UTC (permalink / raw)
  To: notmuch

David Bremner <david@tethera.net> writes:

> Quoting Debian bug 787341
>
>    It failed to build on arm64: the last ten tests in T070-insert
>    failed.
>

included in 20.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-02  2:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-31 16:59 [PATCH] test: remove redundant 'file' command from gdb scripts David Bremner
2015-06-01  9:02 ` Tomi Ollila
2015-06-02  2:58 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).