[PATCH] release-checks: check that git working directory is clean

[PATCH] release-checks: check that git working directory is clean

[Tomi Ollila]

Before release check that there are no uncommitted changes and
that there are no files in working directory that possibly should
have been added to the repository.
---
 devel/release-checks.sh | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/devel/release-checks.sh b/devel/release-checks.sh
index ae02f557af23..eceea6165b5b 100755
--- a/devel/release-checks.sh
+++ b/devel/release-checks.sh
@@ -59,6 +59,17 @@ readonly VERSION
 
 # In the rest of this file, tests collect list of errors to be fixed
 
+echo -n "Checking that git working directory is clean... "
+git_status=`git status --porcelain --ignored`
+if [ "$git_status" = '' ]
+then
+	echo Yes.
+else
+	echo No.
+	append_emsg "Git working directory is not clean (git status --porcelain --ignored)."
+fi
+unset git_status
+
 verfail ()
 {
 	echo No.
-- 
2.0.0

Re: [PATCH] release-checks: check that git working directory is clean

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Before release check that there are no uncommitted changes and
> that there are no files in working directory that possibly should
> have been added to the repository.

this seems ok to me, and certainly reveal just how crufty my notmuch
directory was.

d

Re: [PATCH] release-checks: check that git working directory is clean

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Before release check that there are no uncommitted changes and
> that there are no files in working directory that possibly should
> have been added to the repository.

Not sure the best way to manage this, but I don't think we need to
remove the test (and perf-test) databases do we?

╭─ maritornes:~/software/upstream/notmuch 
╰─ (git)-[master]-% git status --porcelain --ignored
!! test/test-databases/database-v1.tar.xz

Re: [PATCH] release-checks: check that git working directory is clean

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Before release check that there are no uncommitted changes and
> that there are no files in working directory that possibly shoul

pushed, amended as suggested by Tomi on IRC s/--ignored//g