unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] emacs: use (system-name) instead of system-name
@ 2017-02-26  9:28 Jani Nikula
  2017-02-26 10:03 ` Tomi Ollila
  2017-02-26 11:45 ` David Bremner
  0 siblings, 2 replies; 3+ messages in thread
From: Jani Nikula @ 2017-02-26  9:28 UTC (permalink / raw)
  To: notmuch

Fix the deprecation warning:

In notmuch-maildir-fcc-make-uniq-maildir-id:
emacs/notmuch-maildir-fcc.el:279:53:Warning: ‘system-name’ is an obsolete
    variable (as of 25.1); use (system-name) instead

I've used (system-name) since at least 2011, so it must have been
around quite a while.
---
 emacs/notmuch-maildir-fcc.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
index a754b60c7ea3..777658ccfb4a 100644
--- a/emacs/notmuch-maildir-fcc.el
+++ b/emacs/notmuch-maildir-fcc.el
@@ -276,7 +276,7 @@ If CREATE is non-nil then create the folder if necessary."
 (defun notmuch-maildir-fcc-make-uniq-maildir-id ()
    (let* ((ftime (float-time))
 	  (microseconds (mod (* 1000000 ftime) 1000000))
-	  (hostname (notmuch-maildir-fcc-host-fixer system-name)))
+	  (hostname (notmuch-maildir-fcc-host-fixer (system-name))))
      (setq notmuch-maildir-fcc-count (+ notmuch-maildir-fcc-count 1))
      (format "%d.%d_%d_%d.%s"
 	     ftime
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] emacs: use (system-name) instead of system-name
  2017-02-26  9:28 [PATCH] emacs: use (system-name) instead of system-name Jani Nikula
@ 2017-02-26 10:03 ` Tomi Ollila
  2017-02-26 11:45 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2017-02-26 10:03 UTC (permalink / raw)
  To: Jani Nikula, notmuch

On Sun, Feb 26 2017, Jani Nikula <jani@nikula.org> wrote:

> Fix the deprecation warning:
>
> In notmuch-maildir-fcc-make-uniq-maildir-id:
> emacs/notmuch-maildir-fcc.el:279:53:Warning: ‘system-name’ is an obsolete
>     variable (as of 25.1); use (system-name) instead
>
> I've used (system-name) since at least 2011, so it must have been
> around quite a while.

It sure is. LGTM.

Tomi


> ---
>  emacs/notmuch-maildir-fcc.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
> index a754b60c7ea3..777658ccfb4a 100644
> --- a/emacs/notmuch-maildir-fcc.el
> +++ b/emacs/notmuch-maildir-fcc.el
> @@ -276,7 +276,7 @@ If CREATE is non-nil then create the folder if necessary."
>  (defun notmuch-maildir-fcc-make-uniq-maildir-id ()
>     (let* ((ftime (float-time))
>  	  (microseconds (mod (* 1000000 ftime) 1000000))
> -	  (hostname (notmuch-maildir-fcc-host-fixer system-name)))
> +	  (hostname (notmuch-maildir-fcc-host-fixer (system-name))))
>       (setq notmuch-maildir-fcc-count (+ notmuch-maildir-fcc-count 1))
>       (format "%d.%d_%d_%d.%s"
>  	     ftime
> -- 
> 2.11.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] emacs: use (system-name) instead of system-name
  2017-02-26  9:28 [PATCH] emacs: use (system-name) instead of system-name Jani Nikula
  2017-02-26 10:03 ` Tomi Ollila
@ 2017-02-26 11:45 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2017-02-26 11:45 UTC (permalink / raw)
  To: Jani Nikula, notmuch

Jani Nikula <jani@nikula.org> writes:

> Fix the deprecation warning:
>
> In notmuch-maildir-fcc-make-uniq-maildir-id:
> emacs/notmuch-maildir-fcc.el:279:53:Warning: ‘system-name’ is an obsolete
>     variable (as of 25.1); use (system-name) instead

pushed to master

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-26 11:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-26  9:28 [PATCH] emacs: use (system-name) instead of system-name Jani Nikula
2017-02-26 10:03 ` Tomi Ollila
2017-02-26 11:45 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).