unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v1 0/4] Improved citation washing.
Date: Mon, 04 Sep 2017 08:45:11 -0300	[thread overview]
Message-ID: <87tw0iwuuw.fsf@tethera.net> (raw)
In-Reply-To: <20170827134623.20041-1-dme@dme.org>

David Edmondson <dme@dme.org> writes:

> Improved citation washing.
>
> - More aggressive citation washing.
> - Allow washing during text/plain reply generation.
>
> --
>
> I acknowledge that some of the citation washing can seem aggressive at
> times, but it does make my life more pleasant (no more shouting at the
> screen "what was he thinking!" when someone uses a weird quoting
> style).

Aside from the whining about the tests, I have a hard time reviewing
these changes. I tried several messages and nothing exploded, but I
didn't have much of a sense of "yeah, this makes things better", or
"ugh, this is too aggressive". Do you any suggested messages to look at
(maybe from the list?).

Cheers, and thanks working on the emacs UI.

d

      parent reply	other threads:[~2017-09-04 11:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-27 13:46 [PATCH v1 0/4] Improved citation washing David Edmondson
2017-08-27 13:46 ` [PATCH v1 1/4] emacs: wash: Wrap long lines after tidying citations David Edmondson
2017-09-04 11:31   ` David Bremner
2017-08-27 13:46 ` [PATCH v1 2/4] emacs: wash: Improved citation tidying David Edmondson
2017-08-27 13:46 ` [PATCH v1 3/4] emacs: test: Update expected output David Edmondson
2017-09-04 11:34   ` David Bremner
2017-08-27 13:46 ` [PATCH v1 4/4] emacs: reply: Allow washing of inserted text parts during reply David Edmondson
2017-09-04 11:45 ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw0iwuuw.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=dme@dme.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).