From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: cleartext indexing version 5
Date: Mon, 16 Oct 2017 18:40:02 -0700 [thread overview]
Message-ID: <87sheipn65.fsf@ligo.caltech.edu> (raw)
In-Reply-To: <20171015064807.14205-1-dkg@fifthhorseman.net>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On Sun, Oct 15 2017, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
> I welcome review and feedback.
I have reviewed this patch series and everything looks in order. Coding
style is consistent with notmuch standards. The patch is
feature-complete, with appropriate documentation. All tests pass. I am
now using this series by default, with config set to automatically index
encrypted mail ("index.try_decrypt=true"), and have experienced no
issues.
I am strongly in support of this patch series. Daniel is doing crucial
work pushing for widespread use of email encryption. This series is
necessary in the context of that larger goal. He's been pushing this
series for a year and a half now, so I think it's appropriate that it
final be integrated.
jamie.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-10-17 1:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 6:47 cleartext indexing version 5 Daniel Kahn Gillmor
2017-10-15 6:47 ` [PATCH v5 01/12] crypto: move into libnotmuch_util Daniel Kahn Gillmor
2017-10-15 6:47 ` [PATCH v5 02/12] crypto: make shared crypto code behave library-like Daniel Kahn Gillmor
2017-10-15 6:47 ` [PATCH v5 03/12] index: implement notmuch_indexopts_t with try_decrypt Daniel Kahn Gillmor
2017-10-15 6:47 ` [PATCH v5 04/12] properties: add notmuch_message_remove_all_properties_with_prefix() Daniel Kahn Gillmor
2017-10-15 6:48 ` [PATCH v5 05/12] reindex: drop all properties named with prefix "index." Daniel Kahn Gillmor
2017-10-15 6:48 ` [PATCH v5 06/12] crypto: index encrypted parts when indexopts try_decrypt is set Daniel Kahn Gillmor
2017-10-15 6:48 ` [PATCH v5 07/12] config: indexing defaults will be stored in the database Daniel Kahn Gillmor
2017-10-15 6:48 ` [PATCH v5 08/12] config: define new option index.try_decrypt Daniel Kahn Gillmor
2017-10-15 6:48 ` [PATCH v5 09/12] cli: set up shared command-line arguments for indexing Daniel Kahn Gillmor
2017-10-15 6:48 ` [PATCH v5 10/12] cli/new: add --try-decrypt=(true|false) Daniel Kahn Gillmor
2017-10-15 6:48 ` [PATCH v5 11/12] cli/insert: " Daniel Kahn Gillmor
2017-10-15 6:48 ` [PATCH v5 12/12] cli/reindex: " Daniel Kahn Gillmor
2017-10-17 1:40 ` Jameson Graef Rollins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sheipn65.fsf@ligo.caltech.edu \
--to=jrollins@finestructure.net \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).