unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] lib: work around xapian bug with get_mset(0,0, x)
Date: Thu, 19 Apr 2018 07:12:51 -0700	[thread overview]
Message-ID: <87sh7rqo7w.fsf@fifthhorseman.net> (raw)
In-Reply-To: <87muy0nm4t.fsf@tethera.net>

On Wed 2018-04-18 20:13:54 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>> On Fri 2018-04-06 08:43:07 -0300, David Bremner wrote:
>>> At least Fedora28 triggers this Xapian bug due to some toolchain change .
>>>
>>>    https://bugzilla.redhat.com/show_bug.cgi?id=1546162
>>>
>>> The underlying bug is fixed in xapian commit f92e2a936c1592, and
>>> should be fixed in Xapian 1.4.6
>>
>> is there any way that we can apply this change only if we detect that
>> we're running with an unfixed version of Xapian?
>
> It's possible, but I think we'd need a new configure check, and some
> ifdefs. We could consider doing that later, but I don't think it's the
> right approach for a bugfix release.

I was thinking of a runtime check, not a compile-time check -- to ensure
that we drop the workaround as soon as the library is upgraded beneath
us.

But if we want a compile-time check, i don't think we'd need anything
fancier than something like (potentially even directly in query.cc):

    #if XAPIAN_AT_LEAST(1,4,6)
    #define MSET_GET_MIN_COUNT 0
    #else
    #define MSET_GET_MIN_COUNT 1
    #endif

what else were you thinking we'd need?

     --dkg

  reply	other threads:[~2018-04-19 18:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 11:43 [PATCH] lib: work around xapian bug with get_mset(0,0, x) David Bremner
2018-04-15 16:54 ` Tomi Ollila
2018-04-18  0:07   ` [PATCH] NEWS: news item for mset fix David Bremner
2018-04-18  6:59     ` Tomi Ollila
2018-04-18 19:04 ` [PATCH] lib: work around xapian bug with get_mset(0,0, x) Daniel Kahn Gillmor
2018-04-18 23:13   ` David Bremner
2018-04-19 14:12     ` Daniel Kahn Gillmor [this message]
2018-04-20 12:53       ` David Bremner
2018-04-27  1:53 ` David Bremner
2018-04-27  1:53   ` David Bremner
2018-04-28 14:34 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh7rqo7w.fsf@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).