Re: [PATCH] lib: work around xapian bug with get_mset(0,0, x)

[David Bremner <david@tethera.net>]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:


> But if we want a compile-time check, i don't think we'd need anything
> fancier than something like (potentially even directly in query.cc):
>
>     #if XAPIAN_AT_LEAST(1,4,6)
>     #define MSET_GET_MIN_COUNT 0
>     #else
>     #define MSET_GET_MIN_COUNT 1
>     #endif
>
> what else were you thinking we'd need?
>
>      --dkg

I forgot about the XAPIAN_AT_LEAST macro. Nonetheless, I'm not keen to
ship untested/uncompiled code (no matter how "obviously correct" it is),
so I'd prefer to wait until Xapian 1.4.6 actually exists before adding
an ifdef like that. FWIW I doubt that the performance impact of passing
1 instead of 0 here is measurable. For me, getting a bug fix release out
is a matter of some urgency; fine tuning and testing against xapian
1.4.6 can wait.

d