unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* python bindings: fix return value types with ctypes
@ 2019-03-30  9:43 VA
  2019-03-30 17:40 ` Tomi Ollila
  2019-03-31 17:52 ` David Bremner
  0 siblings, 2 replies; 3+ messages in thread
From: VA @ 2019-03-30  9:43 UTC (permalink / raw)
  To: notmuch

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

There were some typos, where restype was misspelled "resttype" and an 
"argtypes" was lost.

[-- Attachment #2: 0001-python-fix-set_sort-add_tag_exclude-restype-argtypes.patch --]
[-- Type: text/x-patch, Size: 1160 bytes --]

From f291f3d20b4683b468c48b35efc6b5ecc2719a1d Mon Sep 17 00:00:00 2001
From: hydrargyrum <dev@indigo.re>
Date: Sat, 30 Mar 2019 10:31:58 +0100
Subject: [PATCH] python: fix set_sort/add_tag_exclude restype/argtypes typos

---
 bindings/python/notmuch/query.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bindings/python/notmuch/query.py b/bindings/python/notmuch/query.py
index 06c7b11b..cc70e2aa 100644
--- a/bindings/python/notmuch/query.py
+++ b/bindings/python/notmuch/query.py
@@ -108,7 +108,7 @@ class Query(object):
 
     _set_sort = nmlib.notmuch_query_set_sort
     _set_sort.argtypes = [NotmuchQueryP, c_uint]
-    _set_sort.argtypes = None
+    _set_sort.restype = None
 
     def set_sort(self, sort):
         """Set the sort order future results will be delivered in
@@ -121,7 +121,7 @@ class Query(object):
 
     _exclude_tag = nmlib.notmuch_query_add_tag_exclude
     _exclude_tag.argtypes = [NotmuchQueryP, c_char_p]
-    _exclude_tag.resttype = None
+    _exclude_tag.restype = None
 
     def exclude_tag(self, tagname):
         """Add a tag that will be excluded from the query results by default.
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: python bindings: fix return value types with ctypes
  2019-03-30  9:43 python bindings: fix return value types with ctypes VA
@ 2019-03-30 17:40 ` Tomi Ollila
  2019-03-31 17:52 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2019-03-30 17:40 UTC (permalink / raw)
  To: VA, notmuch

On Sat, Mar 30 2019, VA wrote:

LGTM (on paper -- checked ctypes doc that '.restype' looks like correctly
spelled name)

> There were some typos, where restype was misspelled "resttype" and an 
> "argtypes" was lost.
> From f291f3d20b4683b468c48b35efc6b5ecc2719a1d Mon Sep 17 00:00:00 2001
> From: hydrargyrum <dev@indigo.re>
> Date: Sat, 30 Mar 2019 10:31:58 +0100
> Subject: [PATCH] python: fix set_sort/add_tag_exclude restype/argtypes typos
>
> ---
>  bindings/python/notmuch/query.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bindings/python/notmuch/query.py b/bindings/python/notmuch/query.py
> index 06c7b11b..cc70e2aa 100644
> --- a/bindings/python/notmuch/query.py
> +++ b/bindings/python/notmuch/query.py
> @@ -108,7 +108,7 @@ class Query(object):
>  
>      _set_sort = nmlib.notmuch_query_set_sort
>      _set_sort.argtypes = [NotmuchQueryP, c_uint]
> -    _set_sort.argtypes = None
> +    _set_sort.restype = None
>  
>      def set_sort(self, sort):
>          """Set the sort order future results will be delivered in
> @@ -121,7 +121,7 @@ class Query(object):
>  
>      _exclude_tag = nmlib.notmuch_query_add_tag_exclude
>      _exclude_tag.argtypes = [NotmuchQueryP, c_char_p]
> -    _exclude_tag.resttype = None
> +    _exclude_tag.restype = None
>  
>      def exclude_tag(self, tagname):
>          """Add a tag that will be excluded from the query results by default.
> -- 
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: python bindings: fix return value types with ctypes
  2019-03-30  9:43 python bindings: fix return value types with ctypes VA
  2019-03-30 17:40 ` Tomi Ollila
@ 2019-03-31 17:52 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2019-03-31 17:52 UTC (permalink / raw)
  To: VA, notmuch

VA <dev+notmuch@indigo.re> writes:

> There were some typos, where restype was misspelled "resttype" and an 
> "argtypes" was lost.

pushed.

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-31 17:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-30  9:43 python bindings: fix return value types with ctypes VA
2019-03-30 17:40 ` Tomi Ollila
2019-03-31 17:52 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).