unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: (wrong-type-argument keymapp notmuch-show-mode-map) in emacs on upgrade to notmuch from master
Date: Thu, 27 May 2021 10:01:16 -0400	[thread overview]
Message-ID: <87sg28wa1f.fsf@fifthhorseman.net> (raw)
In-Reply-To: <877djku9wo.fsf@kyleam.com>


[-- Attachment #1.1: Type: text/plain, Size: 1489 bytes --]

On Wed 2021-05-26 23:34:47 -0400, Kyle Meyer wrote:
> Daniel Kahn Gillmor writes:
>
>> I worry that this is due to one of the two following commits but my
>> elisp-foo is weak enough that i don't know what the right next steps are:
>
> It's due to the second commit, 05a436f7 (emacs: don't fset keymaps,
> 2020-11-11).  You could avoid the error by dropping the quote from the
> keymap variable, changing
>
>   (define-key 'notmuch-show-mode-map "j" 'dkg-notmuch-show-handle-junk)
>
> to
>
>   (define-key notmuch-show-mode-map "j" 'dkg-notmuch-show-handle-junk)

Thanks, this does resolve the issue for me.  I see the patch was
discussed briefly on-list back in November before being merged.

I wonder how many other users will have this problem when upgrading, i
don't know how widespread the use of the quoted variables are in
~/.emacs.  In some sense their removal is a change to the elisp API :/

The conservative API designer in me suggests that rather than removing
these elements directly, we should deprecate first, warning if people
use them (and those warnings should include guidance on how to avoid the
warnings).  Then, after sufficient time has passed, drop the deprecated
element.

This isn't important for me anymore (the issue is resolved for me,
thanks Kyle!), but maybe it will be for others?

If we don't want to go through the full hassle of deprecation and delay
before final removal, it seems like a mention in NEWS is at least
worthwhile.

Regards,

        --dkg

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2021-05-27 14:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27  1:52 (wrong-type-argument keymapp notmuch-show-mode-map) in emacs on upgrade to notmuch from master Daniel Kahn Gillmor
2021-05-27  2:03 ` Daniel Kahn Gillmor
2021-05-27  3:34   ` Kyle Meyer
2021-05-27 14:01     ` Daniel Kahn Gillmor [this message]
2021-05-27 14:50       ` David Bremner
2021-05-27 16:58         ` [PATCH] NEWS/emacs: document changes in 0.32 that affect keybindings Daniel Kahn Gillmor
2021-05-27 17:11           ` Tomi Ollila
2021-05-27 21:46             ` Daniel Kahn Gillmor
2021-05-28 20:59               ` Tomi Ollila
2021-05-31 23:27           ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg28wa1f.fsf@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=kyle@kyleam.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).