From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QHA7KM+vr2AcLAAAgWs5BA (envelope-from ) for ; Thu, 27 May 2021 16:42:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4Cr5I8+vr2CeHQAA1q6Kng (envelope-from ) for ; Thu, 27 May 2021 14:42:23 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5ED1D2645D for ; Thu, 27 May 2021 16:42:23 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id B85E8271C8; Thu, 27 May 2021 10:42:13 -0400 (EDT) Received: from che.mayfirst.org (che.mayfirst.org [IPv6:2001:470:1:116::7]) by mail.notmuchmail.org (Postfix) with ESMTPS id BD4BA26BE0 for ; Thu, 27 May 2021 10:42:10 -0400 (EDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1622126526; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=qv78uRIsdZquRpIA2MXryBmZUOvpEIJiLHVoMplxwWU=; b=sKMdrUUriY3CVcEb+PFTVfzKnB2AtebzebVt4xn+qoNr08PhBR6dzIf4Neyh6X/aId1fl JokdLaV1ZOyNO2QCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1622126526; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=qv78uRIsdZquRpIA2MXryBmZUOvpEIJiLHVoMplxwWU=; b=Hvw33j2fOiIOxDSz/Oml5v6Lp6+jMARdP8t9Va/YhXgfIQCcOTp2rt8RgB0k0ugydHtdM WVHsHs8lY/Cebzuf1lZppNXJA/c6ibWyk00Voem9qp5yNCNjZzAsqZcHSVGJZjUIHqG6M5l Ak0dRP88EKG1cfaTzEPWqV3fPOMFDjNcHAnlAPcporgAoUDd6wli7zggkkc//sRMUDpaGCM JRQ1L3CRlew1ytAkLZlnbg8xSKQtcLZi1FF8rd+jerM9xE23t0oNedzq4nuUqwP2trri0ZO CWUQlrUyMWsEUwXg0F5zyLPE/wtBfqIqJadsrZ2G0gb/lOmlBPu5g4Lldg0Q== Received: from fifthhorseman.net (lair.fifthhorseman.net [108.58.6.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 0B267F9A6; Thu, 27 May 2021 10:42:05 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 1C6BA204CB; Thu, 27 May 2021 10:01:17 -0400 (EDT) From: Daniel Kahn Gillmor To: Kyle Meyer Subject: Re: (wrong-type-argument keymapp notmuch-show-mode-map) in emacs on upgrade to notmuch from master In-Reply-To: <877djku9wo.fsf@kyleam.com> References: <87h7ip2baq.fsf@fifthhorseman.net> <87zgwhvsox.fsf@fifthhorseman.net> <877djku9wo.fsf@kyleam.com> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEX+i03xYJKwYBBAHaRw8BAQdACA4xvL/xI5dHedcnkfViyq84doe8zFRid9jW7CC9XBiI0QQf FgoAgwWCX+i03wWJBZ+mAAMLCQcJEOCS6zpcoQ26RxQAAAAAAB4AIHNhbHRAbm90YXRpb25zLnNl cXVvaWEtcGdwLm9yZ/tr8E9NA10HvcAVlSxnox6z62KXCInWjZaiBIlgX6O5AxUKCAKbAQIeARYh BMKfigwB81402BaqXOCS6zpcoQ26AADZHQD/Zx9nc3N2kj13AUsKMr/7zekBtgfSIGB3hRCU74Su G44A/34Yp6IAkndewLxb1WdRSokycnaCVyrk0nb4imeAYyoPtBc8ZGtnQGZpZnRoaG9yc2VtYW4u bmV0PojRBBMWCgCDBYJf6LTfBYkFn6YAAwsJBwkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3Rh dGlvbnMuc2VxdW9pYS1wZ3Aub3JnL0Gwxvypz2tu1IPG+yu1zPjkiZwpscsitwrVvzN3bbADFQoI ApsBAh4BFiEEwp+KDAHzXjTYFqpc4JLrOlyhDboAAPkXAP0Z29z7jW+YzLzPTQML4EQLMbkHOfU4 +s+ki81Czt0WqgD/SJ8RyrqDCtEP8+E4ZSR01ysKqh+MUAsTaJlzZjehiQ24MwRf6LTfFgkrBgEE AdpHDwEBB0DkKHOW2kmqfAK461+acQ49gc2Z6VoXMChRqobGP0ubb4kBiAQYFgoBOgWCX+i03wWJ BZ+mAAkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3Jnfvo+ nHoxDwaLaJD8XZuXiaqBNZtIGXIypF1udBBRoc0CmwICHgG+oAQZFgoAbwWCX+i03wkQPp1xc3He VlxHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3JnaheiqE7Pfi3Atb3GGTw+ jFcBGOaobgzEJrhEuFpXREEWIQQttUkcnfDcj0MoY88+nXFzcd5WXAAAvrsBAIJ5sBg8Udocv25N stN/zWOiYpnjjvOjVMLH4fV3pWE1AP9T6hzHz7hRnAA8d01vqoxOlQ3O6cb/kFYAjqx3oMXSBhYh BMKfigwB81402BaqXOCS6zpcoQ26AADX7gD/b83VObe14xrNP8xcltRrBZF5OE1rQSPkMNy+eWpk eCwA/1hxiS8ZxL5/elNjXiWuHXEvUGnRoVj745Vl48sZPVYMuDgEX+i03xIKKwYBBAGXVQEFAQEH QIGex1WZbH6xhUBve5mblScGYU+Y8QJOomXH+rr5tMsMAwEICYjJBBgWCgB7BYJf6LTfBYkFn6YA CRDgkus6XKENukcUAAAAAAAeACBzYWx0QG5vdGF0aW9ucy5zZXF1b2lhLXBncC5vcmcEAx9vTD3b J0SXkhvcRcCr6uIDJwic3KFKxkH1m4QW0QKbDAIeARYhBMKfigwB81402BaqXOCS6zpcoQ26AAAX mwD8CWmukxwskU82RZLMk5fm1wCgMB5z8dA50KLw3rgsCykBAKg1w/Y7XpBS3SlXEegIg1K1e6dR fRxL7Z37WZXoH8AH Date: Thu, 27 May 2021 10:01:16 -0400 Message-ID: <87sg28wa1f.fsf@fifthhorseman.net> MIME-Version: 1.0 Message-ID-Hash: NHWCGVC7I3YPESKKF3CA44RUAGNMOIMR X-Message-ID-Hash: NHWCGVC7I3YPESKKF3CA44RUAGNMOIMR X-MailFrom: dkg@fifthhorseman.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Notmuch Mail X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: multipart/mixed; boundary="===============2605317975453439586==" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 5ED1D2645D X-Spam-Score: -4.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: LMBecr+ull9n --===============2605317975453439586== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain On Wed 2021-05-26 23:34:47 -0400, Kyle Meyer wrote: > Daniel Kahn Gillmor writes: > >> I worry that this is due to one of the two following commits but my >> elisp-foo is weak enough that i don't know what the right next steps are: > > It's due to the second commit, 05a436f7 (emacs: don't fset keymaps, > 2020-11-11). You could avoid the error by dropping the quote from the > keymap variable, changing > > (define-key 'notmuch-show-mode-map "j" 'dkg-notmuch-show-handle-junk) > > to > > (define-key notmuch-show-mode-map "j" 'dkg-notmuch-show-handle-junk) Thanks, this does resolve the issue for me. I see the patch was discussed briefly on-list back in November before being merged. I wonder how many other users will have this problem when upgrading, i don't know how widespread the use of the quoted variables are in ~/.emacs. In some sense their removal is a change to the elisp API :/ The conservative API designer in me suggests that rather than removing these elements directly, we should deprecate first, warning if people use them (and those warnings should include guidance on how to avoid the warnings). Then, after sufficient time has passed, drop the deprecated element. This isn't important for me anymore (the issue is resolved for me, thanks Kyle!), but maybe it will be for others? If we don't want to go through the full hassle of deprecation and delay before final removal, it seems like a mention in NEWS is at least worthwhile. Regards, --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQttUkcnfDcj0MoY88+nXFzcd5WXAUCYK+mLAAKCRA+nXFzcd5W XOy6AP9DrT2CqX163x6uB5rjMwflUboAqFmH0if1pDvmYCVeNAEAsb++uEWnbFp7 FeJJB0pN/Ab24VD7HfIiaqfwO8yqqAo= =cz2A -----END PGP SIGNATURE----- --=-=-=-- --===============2605317975453439586== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============2605317975453439586==--