Re: [PATCH] doc: drop use of env with sphinx-build

[David Bremner <david@tethera.net>]

David Bremner <david@tethera.net> writes:

> NOTMUCH_BUILDDIR is not defined in make, only in test scripts, so this
> cannot be doing any good. Without the notmuch2 python module
> installed, it the docs still build, so removing the use of env seems
> to do no harm.
>
> This is a partial revert of 2739549c

It's true that NOTMUCH_BUILDDIR is not defined in make, but I now
understand what that change was trying to accomplish. Autodoc wants to
load the python module, which in turn wants to load the notmuch shared
library. So somehow the doc build needs to find the shared library.

> ---
>  doc/Makefile.local | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/Makefile.local b/doc/Makefile.local
> index 730ad4fb..a8e25037 100644
> --- a/doc/Makefile.local
> +++ b/doc/Makefile.local
> @@ -4,7 +4,7 @@ dir := doc
>  
>  # You can set these variables from the command line.
>  SPHINXOPTS    := -q
> -SPHINXBUILD   = env LD_LIBRARY_PATH=${NOTMUCH_BUILDDIR}/lib sphinx-build
> +SPHINXBUILD   = sphinx-build
>  DOCBUILDDIR      := $(dir)/_build
>  
>  # Internal variables.
> -- 
> 2.33.0