From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sAtvB73Iw2G5+QAAgWs5BA (envelope-from ) for ; Thu, 23 Dec 2021 01:54:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IAhNA73Iw2HFTwAA1q6Kng (envelope-from ) for ; Thu, 23 Dec 2021 00:54:21 +0000 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0DB812753 for ; Thu, 23 Dec 2021 01:54:20 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 2683A5F708; Thu, 23 Dec 2021 00:54:16 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 973545F401 for ; Thu, 23 Dec 2021 00:54:13 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id A9D165FC42; Wed, 22 Dec 2021 19:54:12 -0500 (EST) Received: (nullmailer pid 1373237 invoked by uid 1000); Thu, 23 Dec 2021 00:54:11 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: [PATCH] doc: drop use of env with sphinx-build In-Reply-To: <20211204183849.427098-1-david@tethera.net> References: <20211204183849.427098-1-david@tethera.net> Date: Wed, 22 Dec 2021 20:54:11 -0400 Message-ID: <87r1a4jg3w.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: XOLL5BJIUOJN7U3S6ITBSON7GEBZDA7M X-Message-ID-Hash: XOLL5BJIUOJN7U3S6ITBSON7GEBZDA7M X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640220860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=STtULPL8Y1ey91fGiFzAePH8DTW9/QuaEtnt60so9Kg=; b=MG0XS102d9+gB9gq+k0o9dnthTt3IDHO1MlHHzVoApgk3upqcB8uM2PE+ppjSAkeMKE6e9 lgwtGZ04FhzeWcuv8qTfVysehA7dY6fow4HIqzQ7uo4+lyqqCl6ZK9KjofgAbSb5fF/oUb 2haCIwYNhrr1V4jf05w71S7wDYqry6ZcTd4rVNsibEiaCSZHzne2JZiqtJTBei0iodKNNV EId107nLs06tkudNYdKnPwHxf9Rexrk9ay3QG6W2rmfYUbUch586DDbDunrNbUwmOgNE3K fokknVLz7u9jSIMka2NvE4mDdDpdLp9CL5NpL5r5i+pVkoHs/LdIXLNvsOFa8w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640220860; a=rsa-sha256; cv=none; b=avHv20vj5SG998TUv67rnB0PUSMnADnMhtmad7wMLGGDaJlMDLsh8D8WzfBlYHlGD+62B0 I9/zabIQUfwFPPnMRGzSTv0ohfuOFvqjZjPmx2coMGR/Rr5GJ0FVG75Md1jP8NUBZA6Lz7 48WidlTknx0XsJjMvIuZP7/TR6OAZvxp6ng0CakU8GqVnUmUXm50582we6zj6+1jc4+UL5 jiv1iMfwH4i8rtkfCCsxz1bsG5Ok30kS9naBIizeky8A2a65kdLYvIG4dAduZoqPEIUcKg rSjQp8niNuiGYx1cQJQ37To1J202890ZQ7phfmjs7GOwNufSajFtwnHiUgSmIw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -3.14 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: B0DB812753 X-Spam-Score: -3.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: qSOD1q/sG4J7 David Bremner writes: > NOTMUCH_BUILDDIR is not defined in make, only in test scripts, so this > cannot be doing any good. Without the notmuch2 python module > installed, it the docs still build, so removing the use of env seems > to do no harm. > > This is a partial revert of 2739549c It's true that NOTMUCH_BUILDDIR is not defined in make, but I now understand what that change was trying to accomplish. Autodoc wants to load the python module, which in turn wants to load the notmuch shared library. So somehow the doc build needs to find the shared library. > --- > doc/Makefile.local | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/Makefile.local b/doc/Makefile.local > index 730ad4fb..a8e25037 100644 > --- a/doc/Makefile.local > +++ b/doc/Makefile.local > @@ -4,7 +4,7 @@ dir := doc > > # You can set these variables from the command line. > SPHINXOPTS := -q > -SPHINXBUILD = env LD_LIBRARY_PATH=${NOTMUCH_BUILDDIR}/lib sphinx-build > +SPHINXBUILD = sphinx-build > DOCBUILDDIR := $(dir)/_build > > # Internal variables. > -- > 2.33.0