unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] fix typo in Tags.__len__
@ 2011-08-03 20:47 Cédric Cabessa
  2011-08-09 14:35 ` Sebastian Spaeth
  0 siblings, 1 reply; 2+ messages in thread
From: Cédric Cabessa @ 2011-08-03 20:47 UTC (permalink / raw)
  To: notmuch

Here is a sample that trigger the bug :
"""
import notmuch
db = notmuch.Database()
query = db.create_query("tag:inbox")

for m in query.search_messages():
    len(m.get_tags())

"""
---
 bindings/python/notmuch/tag.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bindings/python/notmuch/tag.py b/bindings/python/notmuch/tag.py
index 65a9118..2f82c1a 100644
--- a/bindings/python/notmuch/tag.py
+++ b/bindings/python/notmuch/tag.py
@@ -116,8 +116,8 @@ class Tags(object):
             raise NotmuchError(STATUS.NOT_INITIALIZED)
 
         i=0
-        while nmlib.notmuch_tags_valid(self._msgs):
-            nmlib.notmuch_tags_move_to_next(self._msgs)
+        while nmlib.notmuch_tags_valid(self._tags):
+            nmlib.notmuch_tags_move_to_next(self._tags)
             i += 1
         self._tags = None
         return i
-- 
1.7.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix typo in Tags.__len__
  2011-08-03 20:47 [PATCH] fix typo in Tags.__len__ Cédric Cabessa
@ 2011-08-09 14:35 ` Sebastian Spaeth
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Spaeth @ 2011-08-09 14:35 UTC (permalink / raw)
  To: Cédric Cabessa, notmuch

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

On Wed,  3 Aug 2011 22:47:21 +0200, Cédric Cabessa <ced@ryick.net> wrote:
> Here is a sample that trigger the bug :
> """
> import notmuch
> db = notmuch.Database()
> query = db.create_query("tag:inbox")
> 
> for m in query.search_messages():
>     len(m.get_tags())

Thanks for the heads up. This has been fixed now in git.

Sebastian

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-09 14:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-03 20:47 [PATCH] fix typo in Tags.__len__ Cédric Cabessa
2011-08-09 14:35 ` Sebastian Spaeth

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).