unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers.
@ 2012-01-16 14:13 David Edmondson
  2012-01-16 21:48 ` Aaron Ecay
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: David Edmondson @ 2012-01-16 14:13 UTC (permalink / raw)
  To: notmuch

Enable the truncation of lines in `notmuch-show-mode' to avoid visual
noise caused by the wrapping of the header lines.

Don't enable `visual-line-mode' because it disables line truncation.

The benefits of `visual-line-mode' were that it wrapped long lines
in received messages. With `notmuch-wash-wrap-long-lines' now default
behaviour, this is no longer required.
---
 emacs/notmuch-show.el |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 1a250a3..797f94b 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -873,9 +873,6 @@ buffer."
 
       (jit-lock-register #'notmuch-show-buttonise-links)
 
-      ;; Act on visual lines rather than logical lines.
-      (visual-line-mode t)
-
       (run-hooks 'notmuch-show-hook))
 
     ;; Move straight to the first open message
@@ -987,7 +984,8 @@ All currently available key bindings:
   (use-local-map notmuch-show-mode-map)
   (setq major-mode 'notmuch-show-mode
 	mode-name "notmuch-show")
-  (setq buffer-read-only t))
+  (setq buffer-read-only t
+	truncate-lines t))
 
 (defun notmuch-show-move-to-message-top ()
   (goto-char (notmuch-show-message-top)))
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers.
  2012-01-16 14:13 [PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers David Edmondson
@ 2012-01-16 21:48 ` Aaron Ecay
  2012-01-18 13:48 ` Pieter Praet
  2012-01-21 13:16 ` David Bremner
  2 siblings, 0 replies; 4+ messages in thread
From: Aaron Ecay @ 2012-01-16 21:48 UTC (permalink / raw)
  To: David Edmondson, notmuch

On Mon, 16 Jan 2012 14:13:22 +0000, David Edmondson <dme@dme.org> wrote:
> Enable the truncation of lines in `notmuch-show-mode' to avoid visual
> noise caused by the wrapping of the header lines.
> 
> Don't enable `visual-line-mode' because it disables line truncation.
> 
> The benefits of `visual-line-mode' were that it wrapped long lines
> in received messages. With `notmuch-wash-wrap-long-lines' now default
> behaviour, this is no longer required.

+1

-- 
Aaron Ecay

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers.
  2012-01-16 14:13 [PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers David Edmondson
  2012-01-16 21:48 ` Aaron Ecay
@ 2012-01-18 13:48 ` Pieter Praet
  2012-01-21 13:16 ` David Bremner
  2 siblings, 0 replies; 4+ messages in thread
From: Pieter Praet @ 2012-01-18 13:48 UTC (permalink / raw)
  To: David Edmondson, notmuch

On Mon, 16 Jan 2012 14:13:22 +0000, David Edmondson <dme@dme.org> wrote:
> Enable the truncation of lines in `notmuch-show-mode' to avoid visual
> noise caused by the wrapping of the header lines.
> 
> Don't enable `visual-line-mode' because it disables line truncation.
> 
> The benefits of `visual-line-mode' were that it wrapped long lines
> in received messages. With `notmuch-wash-wrap-long-lines' now default
> behaviour, this is no longer required.
> ---
>  emacs/notmuch-show.el |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 1a250a3..797f94b 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -873,9 +873,6 @@ buffer."
>  
>        (jit-lock-register #'notmuch-show-buttonise-links)
>  
> -      ;; Act on visual lines rather than logical lines.
> -      (visual-line-mode t)
> -
>        (run-hooks 'notmuch-show-hook))
>  
>      ;; Move straight to the first open message
> @@ -987,7 +984,8 @@ All currently available key bindings:
>    (use-local-map notmuch-show-mode-map)
>    (setq major-mode 'notmuch-show-mode
>  	mode-name "notmuch-show")
> -  (setq buffer-read-only t))
> +  (setq buffer-read-only t
> +	truncate-lines t))
>  
>  (defun notmuch-show-move-to-message-top ()
>    (goto-char (notmuch-show-message-top)))
> -- 
> 1.7.7.3
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

+1


Peace

-- 
Pieter

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers.
  2012-01-16 14:13 [PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers David Edmondson
  2012-01-16 21:48 ` Aaron Ecay
  2012-01-18 13:48 ` Pieter Praet
@ 2012-01-21 13:16 ` David Bremner
  2 siblings, 0 replies; 4+ messages in thread
From: David Bremner @ 2012-01-21 13:16 UTC (permalink / raw)
  To: David Edmondson, notmuch

On Mon, 16 Jan 2012 14:13:22 +0000, David Edmondson <dme@dme.org> wrote:
> Enable the truncation of lines in `notmuch-show-mode' to avoid visual
> noise caused by the wrapping of the header lines.

pushed,

d

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-01-21 13:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-16 14:13 [PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers David Edmondson
2012-01-16 21:48 ` Aaron Ecay
2012-01-18 13:48 ` Pieter Praet
2012-01-21 13:16 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).