Possible bug: wrong from address when forwarding

Possible bug: wrong from address when forwarding

[Mark Walters]

Hi

I am seeing the following bug in the emacs interface: when I forward a
message (f when showing a message) I get a message with the from
address filled in by the host operating system (walters@hostname)
rather than my notmuch configured address. If I compose mail normally
notmuch fills in the correct (notmuch configured) address.

The problem could be in my setup but as far as I can see in
notmuch-mua.el notmuch-mua-forward-message and notmuch-mua-mail behave
differently: the latter fills in the from header with
notmuch-user-primary-email and the former does not.

Mark

Re: Possible bug: wrong from address when forwarding

[Pieter Praet]

---
Either enable `notmuch-always-prompt-for-sender', or apply this
quick-fix patch, which uses `name' and `primary_email' as configured
in your .notmuch-config if aforementioned isn't enabled.

 emacs/notmuch-mua.el |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 274c5da..27c6884 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -213,7 +213,9 @@ the From: address first."
             (user-full-name (car address-components))
             (user-mail-address (cadr address-components)))
        (notmuch-mua-forward-message))
-    (notmuch-mua-forward-message)))
+    (let* ((user-full-name (notmuch-user-name))
+           (user-mail-address (notmuch-user-primary-email)))
+    (notmuch-mua-forward-message))))
 
 (defun notmuch-mua-new-reply (query-string &optional prompt-for-sender)
   "Invoke the notmuch reply window."
-- 
1.7.5.4