* [PATCH] lib: update notmuch_tags_get example to reflect api change
@ 2012-01-30 20:35 Allan Wind
2012-01-30 22:42 ` Austin Clements
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Allan Wind @ 2012-01-30 20:35 UTC (permalink / raw)
To: notmuch
The function notmuch_database_find_message_by_filename now requires a
notmuch_message_t and returns a notmuch_status_t. This
change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2,
version 0.9.
---
lib/notmuch.h | 21 +++++++++++----------
1 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/lib/notmuch.h b/lib/notmuch.h
index 7929fe7..5e6e449 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -941,21 +941,22 @@ notmuch_message_get_header (notmuch_message_t *message, const char *header);
* Typical usage might be:
*
* notmuch_message_t *message;
+ * notmuch_status_t status;
* notmuch_tags_t *tags;
* const char *tag;
*
- * message = notmuch_database_find_message (database, message_id);
- *
- * for (tags = notmuch_message_get_tags (message);
- * notmuch_tags_valid (tags);
- * notmuch_result_move_to_next (tags))
- * {
- * tag = notmuch_tags_get (tags);
- * ....
+ * status = notmuch_database_find_message (database, message_id, &message);
+ * if (!status && message) {
+ * for (tags = notmuch_message_get_tags (message);
+ * notmuch_tags_valid (tags);
+ * notmuch_result_move_to_next (tags))
+ * {
+ * tag = notmuch_tags_get (tags);
+ * ....
+ * }
+ * notmuch_message_destroy (message);
* }
*
- * notmuch_message_destroy (message);
- *
* Note that there's no explicit destructor needed for the
* notmuch_tags_t object. (For consistency, we do provide a
* notmuch_tags_destroy function, but there's no good reason to call
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] lib: update notmuch_tags_get example to reflect api change
2012-01-30 20:35 [PATCH] lib: update notmuch_tags_get example to reflect api change Allan Wind
@ 2012-01-30 22:42 ` Austin Clements
2012-01-30 23:05 ` Allan Wind
2012-01-31 8:31 ` Tomi Ollila
2012-02-04 1:34 ` David Bremner
2 siblings, 1 reply; 6+ messages in thread
From: Austin Clements @ 2012-01-30 22:42 UTC (permalink / raw)
To: Allan Wind, notmuch
Sorry, I replied to the wrong one. This one LGTM.
(BTW, for future reference, it's helpful if you send later versions in
reply to the first version so that they're grouped in threads. Sorry
that the documentation on notmuch's coding conventions is so scattered
and lacking. We're working on it.)
On Mon, 30 Jan 2012 15:35:44 -0500, Allan Wind <allan_wind@lifeintegrity.com> wrote:
> The function notmuch_database_find_message_by_filename now requires a
> notmuch_message_t and returns a notmuch_status_t. This
> change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2,
> version 0.9.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lib: update notmuch_tags_get example to reflect api change
2012-01-30 22:42 ` Austin Clements
@ 2012-01-30 23:05 ` Allan Wind
2012-01-30 23:38 ` Austin Clements
0 siblings, 1 reply; 6+ messages in thread
From: Allan Wind @ 2012-01-30 23:05 UTC (permalink / raw)
To: Austin Clements; +Cc: notmuch
On 2012-01-30 17:42:01, Austin Clements wrote:
> Sorry, I replied to the wrong one. This one LGTM.
>
> (BTW, for future reference, it's helpful if you send later versions in
> reply to the first version so that they're grouped in threads. Sorry
> that the documentation on notmuch's coding conventions is so scattered
> and lacking. We're working on it.)
Will do. I deleted the first message by mistake, and did not see
Message-Ids in the archives. Does git send-email hang on to the
message-ids for replies?
/Allan
--
Allan Wind
Life Integrity, LLC
<http://lifeintegrity.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lib: update notmuch_tags_get example to reflect api change
2012-01-30 23:05 ` Allan Wind
@ 2012-01-30 23:38 ` Austin Clements
0 siblings, 0 replies; 6+ messages in thread
From: Austin Clements @ 2012-01-30 23:38 UTC (permalink / raw)
To: notmuch
Quoth Allan Wind on Jan 30 at 6:05 pm:
> On 2012-01-30 17:42:01, Austin Clements wrote:
> > Sorry, I replied to the wrong one. This one LGTM.
> >
> > (BTW, for future reference, it's helpful if you send later versions in
> > reply to the first version so that they're grouped in threads. Sorry
> > that the documentation on notmuch's coding conventions is so scattered
> > and lacking. We're working on it.)
>
> Will do. I deleted the first message by mistake, and did not see
> Message-Ids in the archives. Does git send-email hang on to the
> message-ids for replies?
That would be nice, but no.
I think you're right that neither the Mailman archive nor Nabble give
access to message IDs. The mbox archive does, of course, though that
requires downloading and hunting through the entire list history
(though I know of an MUA that's really good at that sort of thing).
Another thing you can do to encourage reviewing of multi-version
patches is to add a version number to the subject. It makes it easier
for reviewers to recognize what they have or haven't looked at. git
send-email makes this easy, though non-obvious:
--subject-prefix='PATCH v2' will indicate that a patch (or series) is
version 2 in the conventional way.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lib: update notmuch_tags_get example to reflect api change
2012-01-30 20:35 [PATCH] lib: update notmuch_tags_get example to reflect api change Allan Wind
2012-01-30 22:42 ` Austin Clements
@ 2012-01-31 8:31 ` Tomi Ollila
2012-02-04 1:34 ` David Bremner
2 siblings, 0 replies; 6+ messages in thread
From: Tomi Ollila @ 2012-01-31 8:31 UTC (permalink / raw)
To: Allan Wind, notmuch
On Mon, 30 Jan 2012 15:35:44 -0500, Allan Wind <allan_wind@lifeintegrity.com> wrote:
> The function notmuch_database_find_message_by_filename now requires a
> notmuch_message_t and returns a notmuch_status_t. This
> change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2,
> version 0.9.
LGTM.
Tomi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lib: update notmuch_tags_get example to reflect api change
2012-01-30 20:35 [PATCH] lib: update notmuch_tags_get example to reflect api change Allan Wind
2012-01-30 22:42 ` Austin Clements
2012-01-31 8:31 ` Tomi Ollila
@ 2012-02-04 1:34 ` David Bremner
2 siblings, 0 replies; 6+ messages in thread
From: David Bremner @ 2012-02-04 1:34 UTC (permalink / raw)
To: Allan Wind, notmuch
On Mon, 30 Jan 2012 15:35:44 -0500, Allan Wind <allan_wind@lifeintegrity.com> wrote:
> The function notmuch_database_find_message_by_filename now requires a
> notmuch_message_t and returns a notmuch_status_t. This
> change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2,
> version 0.9.
Hi Allan;
Thanks for all of your work on this. Unfortunately it collides with some
other recently applied patches and needs to be rebased (against master
after I get this machine connected to the net again and push the current
master, hopefully around when this message is sent).
d
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-04 5:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-30 20:35 [PATCH] lib: update notmuch_tags_get example to reflect api change Allan Wind
2012-01-30 22:42 ` Austin Clements
2012-01-30 23:05 ` Allan Wind
2012-01-30 23:38 ` Austin Clements
2012-01-31 8:31 ` Tomi Ollila
2012-02-04 1:34 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).