unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* Tests
@ 2012-07-10 16:51 Mark Walters
  2012-07-14 18:44 ` Tests David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Walters @ 2012-07-10 16:51 UTC (permalink / raw)
  To: notmuch


I have been thinking a little bit about the current situation with
regards to tests. There are quite a lot of tests in the review queue
that have been there for quite some time without much interest, but I do
think we are rather short of tests. (*)

I wonder if we could have a sort of staging area for tests where they
could roughly go in without review and would only be run by something
like make stage-test or make all-tests or something.  The hope is that
this would encourage more tests.

The idea would be not that a patch author would have to make sure they
all pass, but if they previously passed and no longer do then the author
would know *something* about the output had changed.

One example is the emacs elide test by Pieter
id:"1329684990-12504-3-git-send-email-pieter@praet.org" which does still
pass after my substantial change to the way elide is done (and is not
currently covered in the test suite)

Of course if someone does review one of these staging tests then they
can be moved into the real tests.

Best wishes

Mark

(*) for example the structured output patch accidentally changed the
output of notmuch search --output=threads --format=json <search> but
that was not caught by the tests.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Tests
  2012-07-10 16:51 Tests Mark Walters
@ 2012-07-14 18:44 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2012-07-14 18:44 UTC (permalink / raw)
  To: Mark Walters, notmuch

Mark Walters <markwalters1009@gmail.com> writes:

>
> I wonder if we could have a sort of staging area for tests where they
> could roughly go in without review and would only be run by something
> like make stage-test or make all-tests or something.  The hope is that
> this would encourage more tests.

If somebody is willing to take charge of rebasing a "smoke test" branch
that is "master+many tests", probably buildbot could fetch that
directly; I could also pull that into the main repo if that was useful.

d

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-14 18:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-10 16:51 Tests Mark Walters
2012-07-14 18:44 ` Tests David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).