From: Jose A Ortega Ruiz <jao@gnu.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] lib: add better diagnostics for over long filenames.
Date: Sun, 02 Oct 2022 21:03:02 +0100 [thread overview]
Message-ID: <87mtaej8nd.fsf@mail.jao.io> (raw)
In-Reply-To: <20221002175103.541050-2-david@tethera.net>
On Sun, Oct 02 2022, David Bremner wrote:
> Previously we just crashed with an internal error. With this change,
> the caller can handle it better, although the error code could be
> further improved.
This works better for me, yes. A possible improvement is that, with
this patch, one's only warned once about offending files, which are in
subsequent calls to notmuch new simply ignored. I think it'd be better
if we could have a behaviour similar to that for "non-email" files in
the maildir, for which you get a warning every time you run new.
At any rate, many thanks David for the quick response!
Cheers,
jao
--
Contentment is, after all, simply refined indolence.
-Thomas Chandler Haliburton, author, judge, and politician (1796-1865)
next prev parent reply other threads:[~2022-10-02 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 17:51 [PATCH 1/2] test: add known broken test for diagnostics from over long filenames David Bremner
2022-10-02 17:51 ` [PATCH 2/2] lib: add better diagnostics for " David Bremner
2022-10-02 20:03 ` Jose A Ortega Ruiz [this message]
2022-12-27 17:08 ` v2 of long filename diagnostics David Bremner
2022-12-27 17:08 ` [PATCH v2 1/2] test: add known broken test for diagnostics from over long filenames David Bremner
2022-12-27 17:08 ` [PATCH v2 2/2] lib: add better diagnostics for " David Bremner
2023-02-20 13:27 ` v2 of long filename diagnostics David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtaej8nd.fsf@mail.jao.io \
--to=jao@gnu.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).