From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WND1InXwOWPxewEAbAwnHQ (envelope-from ) for ; Sun, 02 Oct 2022 22:11:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gNzkInXwOWNHlAAA9RJhRA (envelope-from ) for ; Sun, 02 Oct 2022 22:11:33 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 56090202F4 for ; Sun, 2 Oct 2022 22:11:33 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5DCD25E020; Sun, 2 Oct 2022 20:03:15 +0000 (UTC) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by mail.notmuchmail.org (Postfix) with ESMTPS id 661685DD5B for ; Sun, 2 Oct 2022 20:03:12 +0000 (UTC) Received: from fencepost.gnu.org ([2001:470:142:3::e]:43906) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1of5B4-0002no-R2; Sun, 02 Oct 2022 16:03:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=mYT6u1+UFa7+GnB8H1M5Sqd2fi/W8+5AggBaj0quXuE=; b=sfaogQq98qPW2z9UQFBS 2ejQVMUZkHPGYvsQhPWE88MBy7pSeItCftBHIWLe2P2JIweSdIyZO8k87nYKIuxgS70BpXG2C+vAo M8miXYIx+ey1u7Y/LQ0yrrJjt5ruZyvyLGtzSQEOZGCY3/6ugsBoP3W72wA7pqzBHB+FmC9oXpnq+ kh7mW0INyANWBmXix49jM7WFswoKqjKnCiBg9CNbYd0JkqgPjK1UKnx5nJRM6aoHUT0p8vXYo2ikZ CEk9869tYvnKFVlpNSYQDH5joeq6N/q/v1uTf7ErWlglBJIhYkeG8qlKRj5Yanyh77iS2KblmcknB j/8WRAmw/bTD+A==; Received: from cpc103048-sgyl39-2-0-cust502.18-2.cable.virginm.net ([92.233.85.247]:58542 helo=rivendell.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1of5B4-0000in-5J; Sun, 02 Oct 2022 16:03:06 -0400 Received: from localhost (rivendell.localdomain [local]) by rivendell.localdomain (OpenSMTPD) with ESMTPA id 4b93d55a; Sun, 2 Oct 2022 20:03:02 +0000 (UTC) From: Jose A Ortega Ruiz To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] lib: add better diagnostics for over long filenames. In-Reply-To: <20221002175103.541050-2-david@tethera.net> References: <20221002175103.541050-1-david@tethera.net> <20221002175103.541050-2-david@tethera.net> X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Date: Sun, 02 Oct 2022 21:03:02 +0100 Message-ID: <87mtaej8nd.fsf@mail.jao.io> MIME-Version: 1.0 Message-ID-Hash: KAXEKFQOVOJOTGZNJFR3SYSK4R3XQHHR X-Message-ID-Hash: KAXEKFQOVOJOTGZNJFR3SYSK4R3XQHHR X-MailFrom: jao@gnu.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664741493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=20/aco2wvaqPnyXJRgMBGrufyz3VVvffOhnorCTKzTA=; b=i943+ermnBYaWlfZLkIFJmcUu37bw6P2A3KGnF1KoADt/pM1A4VNxyh9ruH+dhHSIZFc18 DoTdc5fq1XtH55l9Oqez7vvc7KXmKFbm5S4fq9i76ep0a3JcdokThLuCoPvcxbkMBgbsbp DWG+AAtMSIjt+NH3niH0sJjMcCUiFm2dtDNde1Da4Vmyu7DKL7RXyiV03iTiNUMeAbUQix dsi7grhmnhHrdvUIvDfYIwaYKn/JiWSqUxG7CKnQcRFfODhNtHr6RTo/vXuOHyFibTRAXB 0HEm4cl/aFMtj5NKp1nlKCgoIOtjdXomw8mXNP3WUbBC1gvF5SX33AxcqobAdQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664741493; a=rsa-sha256; cv=none; b=XhKarWM1dDux6PuqJyADdolJ+rQeUi6mbuXVzxo21LQJE3md66ujEl7YxeDaUT4id4RyhG LzGII8/4XF8Vs0r+KNzAg1yvofJBXO+y9E0QmgQdinGl7qHvg5Kf28zuXAIZOIC9EAwHGY 2jcYX0jLVlkYF/7Ot3ISqnmhPADs0Io0Ip5t6YbDo/tlJYnPn7l5JmZX9g/DGUzreCQp8J akXgDqL9+wQq6zkR2R5Q/Ys3T2cD9IDkbG76cqNgFw6my6Sz0H8kSsL+mjwZe1X1bMHQy8 hKu6Nnt47GlFhmOplwKICGgntdgQ2YbJ8FstCFpjfVIY5P+KpwOSYq1n1+ddLg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gnu.org header.s=fencepost-gnu-org header.b=sfaogQq9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gnu.org (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 6.52 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gnu.org header.s=fencepost-gnu-org header.b=sfaogQq9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gnu.org (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 56090202F4 X-Spam-Score: 6.52 X-Migadu-Scanner: scn1.migadu.com X-TUID: 5Xm2ygz0K5Cf On Sun, Oct 02 2022, David Bremner wrote: > Previously we just crashed with an internal error. With this change, > the caller can handle it better, although the error code could be > further improved. This works better for me, yes. A possible improvement is that, with this patch, one's only warned once about offending files, which are in subsequent calls to notmuch new simply ignored. I think it'd be better if we could have a behaviour similar to that for "non-email" files in the maildir, for which you get a warning every time you run new. At any rate, many thanks David for the quick response! Cheers, jao -- Contentment is, after all, simply refined indolence. -Thomas Chandler Haliburton, author, judge, and politician (1796-1865)