From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/5] Notmuch Pick (WIP or contrib)
Date: Wed, 25 Jul 2012 09:27:08 +0530 [thread overview]
Message-ID: <87lii8bii3.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <1343164911-31589-1-git-send-email-markwalters1009@gmail.com>
Mark Walters <markwalters1009@gmail.com> writes:
> Hello
>
> Notmuch pick is an emacs view which displays a threaded view of
> messages: each message has its own line and the thread structure is
> shown with UTF-8 graphics characters (so it looks vaguely similar to
> mutt's threaded view): see http://kanelephant.com/screen.png for a screenshot.
>
> Pick was originally written by David Edmondon and posted on irc and I
> have been developing it on and off since. Now that almost all the
> backend changes it uses are in I would like to see about getting it
> into mainline.
>
> The code is not of the same standard as mainline code: in particular a
> lot of the code is written by me and is working but unidiomatic
> lisp. It has also not had widespread testing so I would expect it to
> have several bugs.
>
> We could try getting it into mainline using the normal review type
> approach, but the patch is necessarily large (it implements a new view
> similar in size to show or search) with the main pick.el file being
> nearly 900 lines.
>
> An alternative approach would be to accept it into contrib and then
> reviewers/users could submit fixes for the problems directly.
>
> This patch series implements the latter approach, but I am definitely
> happy to try for the former or some other approach.
>
I have been using this series for a long time and have not found any
issues. How about adding pick as a part of proper emacs file and have a
config value that disables pick by default. ? So only when
notmuch-enable-pick is set we will load notmuch-pick.el ?
> In its current form the user needs to copy (or link) the
> notmuch-pick.el from contrib into the emacs directory and then build
> notmuch as usual.
With that users won't require to do the above.
>There are two very small patches to "mainline" code:
> one to compile and load the pick file if present and one small tweak
> to notmuch-show.el. Then in contrib/notmuch-pick there are three
> files: the notmuch-pick.el file itself, a README describing
> documenting install and use, and a TODO which contains the main things
> I think need doing (and I will try to update this in light of comments
> received).
>
-aneesh
next prev parent reply other threads:[~2012-07-25 3:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 21:21 [PATCH 0/5] Notmuch Pick (WIP or contrib) Mark Walters
2012-07-24 21:21 ` [PATCH 1/5] emacs: compile and load notmuch-pick.el if present Mark Walters
2012-07-25 9:17 ` Tomi Ollila
2012-07-25 21:12 ` Mark Walters
2012-07-26 2:54 ` Tomi Ollila
2012-09-02 13:54 ` David Bremner
2012-07-24 21:21 ` [PATCH 2/5] emacs: make notmuch-show return its buffer Mark Walters
2012-07-28 17:01 ` Mark Walters
2012-09-02 2:33 ` David Bremner
2012-07-24 21:21 ` [PATCH 3/5] contrib: add notmuch-pick.el file itself Mark Walters
2012-07-24 21:21 ` [PATCH 4/5] contrib: Added pick README Mark Walters
2012-07-24 21:21 ` [PATCH 5/5] contrib: add pick TODO file Mark Walters
2012-07-25 3:57 ` Aneesh Kumar K.V [this message]
2012-09-24 15:00 ` [PATCH 0/5] Notmuch Pick (WIP or contrib) David Bremner
2012-09-30 15:13 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lii8bii3.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).