From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 27027431FC7 for ; Tue, 24 Jul 2012 20:57:23 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QyJemM0tOX4Q for ; Tue, 24 Jul 2012 20:57:20 -0700 (PDT) Received: from e28smtp07.in.ibm.com (e28smtp07.in.ibm.com [122.248.162.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 85C4D431FAF for ; Tue, 24 Jul 2012 20:57:19 -0700 (PDT) Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 Jul 2012 09:27:14 +0530 Received: from d28relay01.in.ibm.com (9.184.220.58) by e28smtp07.in.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 25 Jul 2012 09:27:12 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6P3vBxk28639316 for ; Wed, 25 Jul 2012 09:27:11 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6P3vBSo020795 for ; Wed, 25 Jul 2012 13:57:11 +1000 Received: from skywalker.in.ibm.com.linux.vnet.ibm.com ([9.79.146.110]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q6P3v91f020674; Wed, 25 Jul 2012 13:57:10 +1000 From: "Aneesh Kumar K.V" To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 0/5] Notmuch Pick (WIP or contrib) In-Reply-To: <1343164911-31589-1-git-send-email-markwalters1009@gmail.com> References: <1343164911-31589-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.13.2+63~g548a9bf (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Wed, 25 Jul 2012 09:27:08 +0530 Message-ID: <87lii8bii3.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii x-cbid: 12072503-8878-0000-0000-0000035FD956 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2012 03:57:23 -0000 Mark Walters writes: > Hello > > Notmuch pick is an emacs view which displays a threaded view of > messages: each message has its own line and the thread structure is > shown with UTF-8 graphics characters (so it looks vaguely similar to > mutt's threaded view): see http://kanelephant.com/screen.png for a screenshot. > > Pick was originally written by David Edmondon and posted on irc and I > have been developing it on and off since. Now that almost all the > backend changes it uses are in I would like to see about getting it > into mainline. > > The code is not of the same standard as mainline code: in particular a > lot of the code is written by me and is working but unidiomatic > lisp. It has also not had widespread testing so I would expect it to > have several bugs. > > We could try getting it into mainline using the normal review type > approach, but the patch is necessarily large (it implements a new view > similar in size to show or search) with the main pick.el file being > nearly 900 lines. > > An alternative approach would be to accept it into contrib and then > reviewers/users could submit fixes for the problems directly. > > This patch series implements the latter approach, but I am definitely > happy to try for the former or some other approach. > I have been using this series for a long time and have not found any issues. How about adding pick as a part of proper emacs file and have a config value that disables pick by default. ? So only when notmuch-enable-pick is set we will load notmuch-pick.el ? > In its current form the user needs to copy (or link) the > notmuch-pick.el from contrib into the emacs directory and then build > notmuch as usual. With that users won't require to do the above. >There are two very small patches to "mainline" code: > one to compile and load the pick file if present and one small tweak > to notmuch-show.el. Then in contrib/notmuch-pick there are three > files: the notmuch-pick.el file itself, a README describing > documenting install and use, and a TODO which contains the main things > I think need doing (and I will try to update this in light of comments > received). > -aneesh