* [PATCH] lib/Makefile.local: depend on libs we are linking with
@ 2013-01-21 19:41 Amadeusz Żołnowski
2013-01-21 22:04 ` Jani Nikula
2013-01-22 13:05 ` David Bremner
0 siblings, 2 replies; 4+ messages in thread
From: Amadeusz Żołnowski @ 2013-01-21 19:41 UTC (permalink / raw)
To: notmuch
---
lib/Makefile.local | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Makefile.local b/lib/Makefile.local
index 7785944..155ac02 100644
--- a/lib/Makefile.local
+++ b/lib/Makefile.local
@@ -73,7 +73,7 @@ libnotmuch_modules := $(libnotmuch_c_srcs:.c=.o) $(libnotmuch_cxx_srcs:.cc=.o)
$(dir)/libnotmuch.a: $(libnotmuch_modules)
$(call quiet,AR) rcs $@ $^
-$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym
+$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym util/libutil.a parse-time-string/libparse-time-string.a
$(call quiet,CXX $(CXXFLAGS)) $(libnotmuch_modules) $(FINAL_LIBNOTMUCH_LDFLAGS) $(LIBRARY_LINK_FLAG) -o $@ util/libutil.a parse-time-string/libparse-time-string.a
notmuch.sym: $(srcdir)/$(dir)/notmuch.h $(libnotmuch_modules)
--
1.8.1.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] lib/Makefile.local: depend on libs we are linking with
2013-01-21 19:41 [PATCH] lib/Makefile.local: depend on libs we are linking with Amadeusz Żołnowski
@ 2013-01-21 22:04 ` Jani Nikula
2013-01-22 1:28 ` Tomi Ollila
2013-01-22 13:05 ` David Bremner
1 sibling, 1 reply; 4+ messages in thread
From: Jani Nikula @ 2013-01-21 22:04 UTC (permalink / raw)
To: Amadeusz Żołnowski, notmuch
LGTM, and fixes the issue.
On Mon, 21 Jan 2013, Amadeusz Żołnowski <aidecoe@aidecoe.name> wrote:
> ---
> lib/Makefile.local | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Makefile.local b/lib/Makefile.local
> index 7785944..155ac02 100644
> --- a/lib/Makefile.local
> +++ b/lib/Makefile.local
> @@ -73,7 +73,7 @@ libnotmuch_modules := $(libnotmuch_c_srcs:.c=.o) $(libnotmuch_cxx_srcs:.cc=.o)
> $(dir)/libnotmuch.a: $(libnotmuch_modules)
> $(call quiet,AR) rcs $@ $^
>
> -$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym
> +$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym util/libutil.a parse-time-string/libparse-time-string.a
> $(call quiet,CXX $(CXXFLAGS)) $(libnotmuch_modules) $(FINAL_LIBNOTMUCH_LDFLAGS) $(LIBRARY_LINK_FLAG) -o $@ util/libutil.a parse-time-string/libparse-time-string.a
>
> notmuch.sym: $(srcdir)/$(dir)/notmuch.h $(libnotmuch_modules)
> --
> 1.8.1.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lib/Makefile.local: depend on libs we are linking with
2013-01-21 22:04 ` Jani Nikula
@ 2013-01-22 1:28 ` Tomi Ollila
0 siblings, 0 replies; 4+ messages in thread
From: Tomi Ollila @ 2013-01-22 1:28 UTC (permalink / raw)
To: Jani Nikula, Amadeusz Żołnowski, notmuch
On Tue, Jan 22 2013, Jani Nikula <jani@nikula.org> wrote:
> LGTM, and fixes the issue.
LGTM.
Tomi
>
> On Mon, 21 Jan 2013, Amadeusz Żołnowski <aidecoe@aidecoe.name> wrote:
>> ---
>> lib/Makefile.local | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/Makefile.local b/lib/Makefile.local
>> index 7785944..155ac02 100644
>> --- a/lib/Makefile.local
>> +++ b/lib/Makefile.local
>> @@ -73,7 +73,7 @@ libnotmuch_modules := $(libnotmuch_c_srcs:.c=.o) $(libnotmuch_cxx_srcs:.cc=.o)
>> $(dir)/libnotmuch.a: $(libnotmuch_modules)
>> $(call quiet,AR) rcs $@ $^
>>
>> -$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym
>> +$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym util/libutil.a parse-time-string/libparse-time-string.a
>> $(call quiet,CXX $(CXXFLAGS)) $(libnotmuch_modules) $(FINAL_LIBNOTMUCH_LDFLAGS) $(LIBRARY_LINK_FLAG) -o $@ util/libutil.a parse-time-string/libparse-time-string.a
>>
>> notmuch.sym: $(srcdir)/$(dir)/notmuch.h $(libnotmuch_modules)
>> --
>> 1.8.1.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lib/Makefile.local: depend on libs we are linking with
2013-01-21 19:41 [PATCH] lib/Makefile.local: depend on libs we are linking with Amadeusz Żołnowski
2013-01-21 22:04 ` Jani Nikula
@ 2013-01-22 13:05 ` David Bremner
1 sibling, 0 replies; 4+ messages in thread
From: David Bremner @ 2013-01-22 13:05 UTC (permalink / raw)
To: Amadeusz Żołnowski, notmuch
Amadeusz Żołnowski <aidecoe@aidecoe.name> writes:
> ---
> lib/Makefile.local | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Pushed. Although a slightly more verbose commit message would have been
nice.
d
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-22 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-21 19:41 [PATCH] lib/Makefile.local: depend on libs we are linking with Amadeusz Żołnowski
2013-01-21 22:04 ` Jani Nikula
2013-01-22 1:28 ` Tomi Ollila
2013-01-22 13:05 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).