* [PATCH] test: aggregate-results.sh: count test files where all tests skipped
@ 2019-06-15 14:28 Tomi Ollila
2019-07-02 16:47 ` Daniel Kahn Gillmor
2019-07-05 16:00 ` David Bremner
0 siblings, 2 replies; 3+ messages in thread
From: Tomi Ollila @ 2019-06-15 14:28 UTC (permalink / raw)
To: notmuch; +Cc: tomi.ollila
Previously, when all tests were skipped on a test file, there were
no indication of this in the final results aggregate-results.sh
printed.
Now count of the files where all tests were skipped is printed.
---
test/aggregate-results.sh | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/test/aggregate-results.sh b/test/aggregate-results.sh
index 05fb0a92..75400e6e 100755
--- a/test/aggregate-results.sh
+++ b/test/aggregate-results.sh
@@ -7,6 +7,7 @@ success=0
failed=0
broken=0
total=0
+all_skipped=0
for file
do
@@ -22,7 +23,10 @@ do
broken)
broken=$((broken + value)) ;;
total)
- total=$((total + value)) ;;
+ total=$((total + value))
+ if [ "$value" -eq 0 ]; then
+ all_skipped=$((all_skipped + 1))
+ fi
esac
done <"$file"
done
@@ -61,6 +65,10 @@ if [ "$skipped" -ne 0 ]; then
pluralize_s "$skipped"
echo "$skipped test$s skipped."
fi
+if [ "$all_skipped" -ne 0 ]; then
+ pluralize_s "$all_skipped"
+ echo "All tests in $all_skipped file$s skipped."
+fi
# Note that we currently do not consider skipped tests as failing the
# build.
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] test: aggregate-results.sh: count test files where all tests skipped
2019-06-15 14:28 [PATCH] test: aggregate-results.sh: count test files where all tests skipped Tomi Ollila
@ 2019-07-02 16:47 ` Daniel Kahn Gillmor
2019-07-05 16:00 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Kahn Gillmor @ 2019-07-02 16:47 UTC (permalink / raw)
To: Tomi Ollila, notmuch
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
On Sat 2019-06-15 17:28:44 +0300, Tomi Ollila wrote:
> Previously, when all tests were skipped on a test file, there were
> no indication of this in the final results aggregate-results.sh
> printed.
> Now count of the files where all tests were skipped is printed.
LGTM. thanks for proposing this, Tomi.
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test: aggregate-results.sh: count test files where all tests skipped
2019-06-15 14:28 [PATCH] test: aggregate-results.sh: count test files where all tests skipped Tomi Ollila
2019-07-02 16:47 ` Daniel Kahn Gillmor
@ 2019-07-05 16:00 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2019-07-05 16:00 UTC (permalink / raw)
To: Tomi Ollila, notmuch; +Cc: tomi.ollila
Tomi Ollila <tomi.ollila@iki.fi> writes:
> Previously, when all tests were skipped on a test file, there were
> no indication of this in the final results aggregate-results.sh
> printed.
> Now count of the files where all tests were skipped is printed.
pushed
d
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-10 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-15 14:28 [PATCH] test: aggregate-results.sh: count test files where all tests skipped Tomi Ollila
2019-07-02 16:47 ` Daniel Kahn Gillmor
2019-07-05 16:00 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).