From: Jose A Ortega Ruiz <jao@gnu.org>
To: David Bremner <david@tethera.net>,
Tomi Ollila <tomi.ollila@iki.fi>,
notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/1] emacs: notmuch-show-header-line: allow format strings and functions
Date: Wed, 18 May 2022 20:31:30 +0100 [thread overview]
Message-ID: <87ilq263jh.fsf@gnus.jao.io> (raw)
In-Reply-To: <87sfp7b1sm.fsf@tethera.net>
On Wed, May 18 2022, David Bremner wrote:
> Jose A Ortega Ruiz <jao@gnu.org> writes:
>
>> On Tue, May 17 2022, Tomi Ollila wrote:
>>
>>
>> [...]
>>
>>> To me it looks like some lines are indented with tabs and some spaces
>>> (noticed as indentation looked weird to me and then started moving cursor
>>> at the beginning of line -- there is probably a way to highlight tabs in
>>> notmuch show buffer but...)
>>
>> oh, i've got that highlight on, and i see spaces and tabs mixed all over
>> the place, so i didn't pay attention: i have emacs configured to indent
>> using spaces, am i supposed to use tabs for notmuch elisp? or just not
>> mix the two in the same block?
>>
>
> If you run "devel/check-notmuch-commit" (or the embedded emacs command)
> it will "do the right thing" for indenting elisp. Basically however
> emacs -Q does it.
Ah, thanks. I did that now in a new version of the patch. Hopefully i
got it right this time. I also refactored out a separate function, as
discussed with Tomi.
Cheers,
jao
--
He is a hard man who is only just, and a sad one who is only
wise. -Voltaire, philosopher (1694-1778)
next prev parent reply other threads:[~2022-05-18 19:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 2:20 [PATCH v2 0/1] notmuch-show-header-line: allow format strings and functions jao
2022-05-16 2:20 ` [PATCH v2 1/1] emacs: " jao
2022-05-17 20:30 ` Tomi Ollila
2022-05-17 21:41 ` Jose A Ortega Ruiz
2022-05-18 9:58 ` David Bremner
2022-05-18 19:31 ` Jose A Ortega Ruiz [this message]
2022-05-17 21:49 ` Jose A Ortega Ruiz
2022-05-18 13:36 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilq263jh.fsf@gnus.jao.io \
--to=jao@gnu.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).