From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kLdKIptJhWKbLQEAbAwnHQ (envelope-from ) for ; Wed, 18 May 2022 21:31:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id INtbIZtJhWLKigAAG6o9tA (envelope-from ) for ; Wed, 18 May 2022 21:31:39 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3B6371CBDE for ; Wed, 18 May 2022 21:31:39 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id AACFB5F76E; Wed, 18 May 2022 19:31:37 +0000 (UTC) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by mail.notmuchmail.org (Postfix) with ESMTPS id 05CF65F75B for ; Wed, 18 May 2022 19:31:36 +0000 (UTC) Received: from fencepost.gnu.org ([2001:470:142:3::e]:38062) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrPOP-0000HT-L5; Wed, 18 May 2022 15:31:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=N44YiodPCJwDPUmTGL7TCKNDxJlJeE0MQGB+Qr5kgQ0=; b=IJkiKGdaynZ8cq0U+R2K osOs6d6DtKBCzcvRxOF3Jn6NZeQ8NgbgFVMAVNF0b445flr9rFBMAvImZ3+oAndnOLODNEn9rCLf1 VYaO1mCqfF86sJGB/zki/BD9dvKepVyGHOWX1HuAE84+aBJBv/y5PXT77iKE6stYY761nMsXeguwg 5sDFJzxbdWEY0EeJ5jCtk5nBv0p2mC5QqMy1akXSwCTx1svFFlW268IkJvx28jm7HmsmBQve+DWuh DWs0/53Fu6GL4MZg/jNKmAvC3XMoJX6Cz7c8PVRPbX7Riy0A/V1+R6cF6J2/2RL1/sv/9OR7ranAO NAgf7HGpHnqYIA==; Received: from cpc103048-sgyl39-2-0-cust502.18-2.cable.virginm.net ([92.233.85.247]:39520 helo=rivendell.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrPOP-00061d-8N; Wed, 18 May 2022 15:31:33 -0400 Received: from localhost (rivendell.localdomain [local]) by rivendell.localdomain (OpenSMTPD) with ESMTPA id 974cee28; Wed, 18 May 2022 19:31:30 +0000 (UTC) From: Jose A Ortega Ruiz To: David Bremner , Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH v2 1/1] emacs: notmuch-show-header-line: allow format strings and functions In-Reply-To: <87sfp7b1sm.fsf@tethera.net> References: <20220516022039.551596-1-jao@gnu.org> <20220516022039.551596-2-jao@gnu.org> <871qwr96rb.fsf@gnus.jao.io> <87sfp7b1sm.fsf@tethera.net> X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Date: Wed, 18 May 2022 20:31:30 +0100 Message-ID: <87ilq263jh.fsf@gnus.jao.io> MIME-Version: 1.0 Message-ID-Hash: 7FTT4IQMYMC4MQD4JPFYEOSCJDFOYX3J X-Message-ID-Hash: 7FTT4IQMYMC4MQD4JPFYEOSCJDFOYX3J X-MailFrom: jao@gnu.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652902299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=4vx3TIa70Eetfw4s2Gt/uFP1aNmxZZHOPECESVKbQ44=; b=mbltTiRBQrvjYSd4VrmpGumwD5TPcNMZQybF914lFdDQUrammKIkaX5sXZFiXG9oOxD5DG dIs19qZvPb8WM2hfzMosjz1uzZ1B8rZkpnJ/5ojCg05Ysjpc2oWWKwnvXdyJZyC0QiUhwU sbedSVkCq8PqU3p5S9m1Vs+HUUH6CEfLj4pB/98qNZeVqeYbNXgCACh3y2fVLVMGGFUsIh LBCf92CBrrJjOWK/RIPtTdfc9Os+7JxKsyMYkYMK6Tlmz9ktTEifeGFY0jHdy+KMTnuYIo i8XtaINcctWwTWux6aosEIzd5RqSfUzHbcmOIFdrr0B2NBNd5xGw3k45YdyEzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652902299; a=rsa-sha256; cv=none; b=hAUxNdviuxvLRfI/kT39zu3j+eVuASDKS6B1JfUQvlo6gJZlnYNXOugRjifCoI9lrc6SOP M/6+MYPw5rgcJ/b060LG5YI1b52LA9nobbUwtjo+m5PQrpQXR0R3lNI2QkphwRDVm8V1a3 FzlKkX0hpW7AVkNxI7NTd3CXHLZwPhs9ywIdEVfav3M4686HFY4OczgHxcqbZ4RpEoIBSF 5SCZMaxUOYgDfbhYFdo0x/zi01iwp6qBU6poJtHHeIeeHV+dIWW5acZcQ0YTK74iXhrwrt MPt9Y+MZhul4H9GPlnkSB85rqorYsYQ1WVTbBPJhjYKq0wfKK7ZA7TSA/sPnwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gnu.org header.s=fencepost-gnu-org header.b=IJkiKGda; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gnu.org (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 6.63 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gnu.org header.s=fencepost-gnu-org header.b=IJkiKGda; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gnu.org (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 3B6371CBDE X-Spam-Score: 6.63 X-Migadu-Scanner: scn0.migadu.com X-TUID: 78OCElyNyanK On Wed, May 18 2022, David Bremner wrote: > Jose A Ortega Ruiz writes: > >> On Tue, May 17 2022, Tomi Ollila wrote: >> >> >> [...] >> >>> To me it looks like some lines are indented with tabs and some spaces >>> (noticed as indentation looked weird to me and then started moving cursor >>> at the beginning of line -- there is probably a way to highlight tabs in >>> notmuch show buffer but...) >> >> oh, i've got that highlight on, and i see spaces and tabs mixed all over >> the place, so i didn't pay attention: i have emacs configured to indent >> using spaces, am i supposed to use tabs for notmuch elisp? or just not >> mix the two in the same block? >> > > If you run "devel/check-notmuch-commit" (or the embedded emacs command) > it will "do the right thing" for indenting elisp. Basically however > emacs -Q does it. Ah, thanks. I did that now in a new version of the patch. Hopefully i got it right this time. I also refactored out a separate function, as discussed with Tomi. Cheers, jao -- He is a hard man who is only just, and a sad one who is only wise. -Voltaire, philosopher (1694-1778)