From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t
Date: Sun, 21 Oct 2012 09:03:08 -0400 [thread overview]
Message-ID: <87hapo565v.fsf@betacantrips.com> (raw)
In-Reply-To: <20121021130427.GA4820@hili.localdomain>
Peter Wang <novalazy@gmail.com> writes:
> Does it help if you add a "sleep 1" before the second generate_message
> call, i.e. on line 35?
It turns out that this test failure is sporadic (perhaps due to the fact
that I'm running on tmpfs) and exists even before this series. Doing
"sleep 1" makes it go away, but that "fix" is unrelated to this series
and ought to be fixed elsewhere.
> I have to disagree. The condition is wrapped over two lines. The then
> part is wrapped over two lines. The else part already has braces.
> All suggest braces around the then part.
If Tomi is OK with it, then I guess it's fine. And it's true that there
are a couple of places where braces are used with long conditions and
then-parts.
This series has my +1.
Ethan
next prev parent reply other threads:[~2012-10-21 13:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 13:28 [PATCH 0/8] search --exclude=all Peter Wang
2012-06-20 13:29 ` [PATCH 1/8] lib: add --exclude=all option Peter Wang
2013-05-11 18:07 ` David Bremner
2012-06-20 13:29 ` [PATCH 2/8] cli: add --exclude=all option to notmuch-search.c Peter Wang
2012-06-20 13:29 ` [PATCH 3/8] test: add tests for search --exclude=all Peter Wang
2012-06-20 13:29 ` [PATCH 4/8] man: clarify search --exclude documentation Peter Wang
2012-06-20 20:08 ` Mark Walters
2012-06-23 2:02 ` Peter Wang
2012-06-23 7:14 ` Mark Walters
2012-06-20 13:29 ` [PATCH 5/8] man: clarify search --exclude=flag Peter Wang
2012-06-20 13:29 ` [PATCH 6/8] man: document search --exclude=all Peter Wang
2012-06-20 13:29 ` [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t Peter Wang
2012-10-19 5:15 ` Ethan Glasser-Camp
2012-10-19 21:23 ` Ethan Glasser-Camp
2012-10-20 10:04 ` Tomi Ollila
2012-10-21 2:04 ` Peter Wang
2012-10-21 12:10 ` Tomi Ollila
2012-10-21 13:03 ` Ethan Glasser-Camp [this message]
2012-06-20 13:29 ` [PATCH 8/8] cli: use notmuch_exclude_t in option parser Peter Wang
2012-07-22 1:18 ` [PATCH v2 4/8] man: clarify search --exclude documentation Peter Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hapo565v.fsf@betacantrips.com \
--to=ethan.glasser.camp@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=novalazy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).