From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7A463431FAF for ; Sun, 21 Oct 2012 06:03:12 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jfd8Bcy4L0hN for ; Sun, 21 Oct 2012 06:03:12 -0700 (PDT) Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 16CB8431FAE for ; Sun, 21 Oct 2012 06:03:12 -0700 (PDT) Received: by mail-vb0-f53.google.com with SMTP id fc21so2157855vbb.26 for ; Sun, 21 Oct 2012 06:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=FhAsPqeF/ajix1TtG9FfCEbWav128lPnAq2TvMrpwmc=; b=VHbxD+23x1kMmVZCj1+l9eHd5qmyJlZu6jho+mk1yI3eMbrSrzrg7MgXpz6f2/H/ga APvV/loeMGqEVieeeiuPCp9GMgm+N0Bm07UKclsTYJZcTu2S8aVL2oEy6H+kPaFqeGQf JDhM5NpmRjQ/fy0slZNwGK03Wp4rPwe+sgaYlZxMt8n/iWrb5zSZQKf0X+A6VvZaw/v2 RJ91Ys4Agol2TLSOyIY6PnSjVKU5432PgMyTDS4dXTiYq0NftZsl7fonmFGKLuZvBUKT /Hof6CrM+ko8EJ9FSo9upfOP+xNm0rM0xhK9xh63QHNjS7OCJTwaRXi8F+Hsl2yiOJvQ GikQ== Received: by 10.52.97.200 with SMTP id ec8mr7796169vdb.89.1350824591533; Sun, 21 Oct 2012 06:03:11 -0700 (PDT) Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) by mx.google.com with ESMTPS id u2sm7213017vdt.11.2012.10.21.06.03.10 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 21 Oct 2012 06:03:10 -0700 (PDT) From: Ethan Glasser-Camp To: Peter Wang , notmuch@notmuchmail.org Subject: Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t In-Reply-To: <20121021130427.GA4820@hili.localdomain> References: <1340198947-29370-1-git-send-email-novalazy@gmail.com> <1340198947-29370-8-git-send-email-novalazy@gmail.com> <87txtr6o0c.fsf@betacantrips.com> <20121021130427.GA4820@hili.localdomain> User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sun, 21 Oct 2012 09:03:08 -0400 Message-ID: <87hapo565v.fsf@betacantrips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2012 13:03:12 -0000 Peter Wang writes: > Does it help if you add a "sleep 1" before the second generate_message > call, i.e. on line 35? It turns out that this test failure is sporadic (perhaps due to the fact that I'm running on tmpfs) and exists even before this series. Doing "sleep 1" makes it go away, but that "fix" is unrelated to this series and ought to be fixed elsewhere. > I have to disagree. The condition is wrapped over two lines. The then > part is wrapped over two lines. The else part already has braces. > All suggest braces around the then part. If Tomi is OK with it, then I guess it's fine. And it's true that there are a couple of places where braces are used with long conditions and then-parts. This series has my +1. Ethan