* [PATCH] lib: fix the todo comment placement on NOTMUCH_STATUS_XAPIAN_EXCEPTION
@ 2016-12-17 11:05 Jani Nikula
2017-01-07 12:36 ` David Bremner
0 siblings, 1 reply; 2+ messages in thread
From: Jani Nikula @ 2016-12-17 11:05 UTC (permalink / raw)
To: notmuch
The todo comment got separated from the status it's related to at
commit 3f32fd8a1c06 ("Add missing comment for
NOTMUCH_STATUS_READONLY_DATABASE."). Later, commit b65ca8e0ba5e ("lib:
modify notmuch.h for automatic document generation") moved it, but to
the wrong place. Fix the location.
---
lib/notmuch.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/notmuch.h b/lib/notmuch.h
index 18678c0a766c..59cd0f564fc1 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -126,15 +126,15 @@ typedef enum _notmuch_status {
NOTMUCH_STATUS_READ_ONLY_DATABASE,
/**
* A Xapian exception occurred.
+ *
+ * @todo We don't really want to expose this lame XAPIAN_EXCEPTION
+ * value. Instead we should map to things like DATABASE_LOCKED or
+ * whatever.
*/
NOTMUCH_STATUS_XAPIAN_EXCEPTION,
/**
* An error occurred trying to read or write to a file (this could
* be file not found, permission denied, etc.)
- *
- * @todo We don't really want to expose this lame XAPIAN_EXCEPTION
- * value. Instead we should map to things like DATABASE_LOCKED or
- * whatever.
*/
NOTMUCH_STATUS_FILE_ERROR,
/**
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lib: fix the todo comment placement on NOTMUCH_STATUS_XAPIAN_EXCEPTION
2016-12-17 11:05 [PATCH] lib: fix the todo comment placement on NOTMUCH_STATUS_XAPIAN_EXCEPTION Jani Nikula
@ 2017-01-07 12:36 ` David Bremner
0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2017-01-07 12:36 UTC (permalink / raw)
To: Jani Nikula, notmuch
Jani Nikula <jani@nikula.org> writes:
> The todo comment got separated from the status it's related to at
> commit 3f32fd8a1c06 ("Add missing comment for
> NOTMUCH_STATUS_READONLY_DATABASE."). Later, commit b65ca8e0ba5e ("lib:
> modify notmuch.h for automatic document generation") moved it, but to
> the wrong place. Fix the location.
pushed
d
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-07 12:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-17 11:05 [PATCH] lib: fix the todo comment placement on NOTMUCH_STATUS_XAPIAN_EXCEPTION Jani Nikula
2017-01-07 12:36 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).