unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: NeilBrown <neilb@suse.de>
Cc: notmuch@notmuchmail.org
Subject: Re: WIP: filter out envelope headers in notmuch-insert.
Date: Mon, 14 Feb 2022 07:16:58 -0400	[thread overview]
Message-ID: <87h791wvdh.fsf@tethera.net> (raw)
In-Reply-To: <164481580222.17471.7090984749734305531@noble.neil.brown.name>

"NeilBrown" <neilb@suse.de> writes:

> On Sat, 12 Feb 2022, David Bremner wrote:
>> This is a bit rough and ready, but before I fine tune it, I want to
>> make sure the overall idea of stripping envelope headers in
>> notmuch-insert makes sense.
>
> I think that it would be highly inappropriate to modify the message
> passed to notmuch-insert AT ALL.
> It *might* be appropriate to check that it looks generally like an email
> message (e.g.  headers followed by a blank line), but changing it would
> be wrong.
>

Here we're just changing "From  foo" into "X-Envelope-From: foo",
so no information is lost, unless you consider being an mbox file
information.

> Why do you think it might be helpful?

Currently we throw an error from notmuch-insert when trying to index
those mbox files (as passed to notmuch-insert by postfix). This means
the message is either bounced or (with --keep), invisible in the notmuch
index.

d

  parent reply	other threads:[~2022-02-14 11:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-12  2:55 WIP: filter out envelope headers in notmuch-insert David Bremner
2022-02-12  2:55 ` [RFC PATCH 1/3] test: start new corpus of test messages for indexing code David Bremner
2022-02-12  2:55 ` [RFC PATCH 2/3] test: add known broken test for insert with mbox as input David Bremner
2022-02-12  2:55 ` [RFC PATCH 3/3] WIP: escape envelope from David Bremner
2022-02-12 11:34 ` WIP: filter out envelope headers in notmuch-insert David Bremner
2022-02-13 14:06   ` David Bremner
     [not found] ` <164481580222.17471.7090984749734305531@noble.neil.brown.name>
2022-02-14 11:16   ` David Bremner [this message]
2022-02-14 22:23     ` NeilBrown
2022-02-14 23:52       ` David Bremner
2022-02-15  1:13         ` NeilBrown
2022-02-15  2:15           ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h791wvdh.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=neilb@suse.de \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).