Re: WIP: filter out envelope headers in notmuch-insert.

[NeilBrown <neil@brown.name>]

On Tue, 15 Feb 2022, David Bremner wrote:
> "NeilBrown" <neilb@suse.de> writes:
> 
> > On Mon, 14 Feb 2022, David Bremner wrote:
> >
> > If notmuch-insert is given an 'mbox', shouldn't it either reject it, or
> > split it up into individual messages and insert each one individually
> > (discarding the "From" line because it shouldn't add any new
> > information)?
> 
> I guess you could think of what the patch does as a conservative version
> of that.  I'm not aware of any case where a "real" mbox with multiple
> messages is passed to notmuch-insert. So the modification effectively
> discards the From line, although keeping the contents, because who knows
> what people rely on.

And on digging into postfix a bit, it seem that when forwarding to a
program, it *doesn't* quote other "From " lines in the email, so
splitting up the input would break things.  I wonder if that is a bug...
the documentation is clear on the details of delivering to a program

> 
> > I don't suppose there is some config option to postfix to tell it to
> > provide an RFC-2822 email message, not an mbox ???
> 
> It seems not, at least for the case of invoking notmuch-insert via a
> .forward file, which I would guess is the most common case (nothing
> specific to postfix, it's just the obvious way to invoke
> notmuch-insert).

So it seems... In the case of postfix the sender information is provided
both in "From " and "Return-Path:", so just stripping "From " would be
safe.  It is hard to argue against the extra caution of retaining the
from line in an "X-Envolope-from" though.

Thanks,
NeilBrown