* [PATCH] emacs: Don't record undo information for search or show buffers.
@ 2011-11-21 1:00 Austin Clements
2011-11-21 1:07 ` Dmitry Kurochkin
2011-11-24 12:53 ` David Bremner
0 siblings, 2 replies; 3+ messages in thread
From: Austin Clements @ 2011-11-21 1:00 UTC (permalink / raw)
To: notmuch
There's no reason to record undo information for read-only,
programmatically-constructed buffers. The undo list just chews up
memory keeping track of our calls to insert.
---
emacs/notmuch-show.el | 2 ++
emacs/notmuch.el | 2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index d5c95d8..7689867 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -843,6 +843,8 @@ buffer."
(inhibit-read-only t))
(switch-to-buffer buffer)
(notmuch-show-mode)
+ ;; Don't track undo information for this buffer
+ (set 'buffer-undo-list t)
(setq notmuch-show-thread-id thread-id)
(setq notmuch-show-parent-buffer parent-buffer)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index c1827cc..a8e4d62 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -920,6 +920,8 @@ The optional parameters are used as follows:
(let ((buffer (get-buffer-create (notmuch-search-buffer-title query))))
(switch-to-buffer buffer)
(notmuch-search-mode)
+ ;; Don't track undo information for this buffer
+ (set 'buffer-undo-list t)
(set 'notmuch-search-query-string query)
(set 'notmuch-search-oldest-first oldest-first)
(set 'notmuch-search-target-thread target-thread)
--
1.7.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] emacs: Don't record undo information for search or show buffers.
2011-11-21 1:00 [PATCH] emacs: Don't record undo information for search or show buffers Austin Clements
@ 2011-11-21 1:07 ` Dmitry Kurochkin
2011-11-24 12:53 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Kurochkin @ 2011-11-21 1:07 UTC (permalink / raw)
To: Austin Clements, notmuch
On Sun, 20 Nov 2011 20:00:55 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> There's no reason to record undo information for read-only,
> programmatically-constructed buffers. The undo list just chews up
> memory keeping track of our calls to insert.
Makes sense and looks good!
Regards,
Dmitry
> ---
> emacs/notmuch-show.el | 2 ++
> emacs/notmuch.el | 2 ++
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index d5c95d8..7689867 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -843,6 +843,8 @@ buffer."
> (inhibit-read-only t))
> (switch-to-buffer buffer)
> (notmuch-show-mode)
> + ;; Don't track undo information for this buffer
> + (set 'buffer-undo-list t)
>
> (setq notmuch-show-thread-id thread-id)
> (setq notmuch-show-parent-buffer parent-buffer)
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index c1827cc..a8e4d62 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -920,6 +920,8 @@ The optional parameters are used as follows:
> (let ((buffer (get-buffer-create (notmuch-search-buffer-title query))))
> (switch-to-buffer buffer)
> (notmuch-search-mode)
> + ;; Don't track undo information for this buffer
> + (set 'buffer-undo-list t)
> (set 'notmuch-search-query-string query)
> (set 'notmuch-search-oldest-first oldest-first)
> (set 'notmuch-search-target-thread target-thread)
> --
> 1.7.7.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] emacs: Don't record undo information for search or show buffers.
2011-11-21 1:00 [PATCH] emacs: Don't record undo information for search or show buffers Austin Clements
2011-11-21 1:07 ` Dmitry Kurochkin
@ 2011-11-24 12:53 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2011-11-24 12:53 UTC (permalink / raw)
To: Austin Clements, notmuch
On Sun, 20 Nov 2011 20:00:55 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> There's no reason to record undo information for read-only,
> programmatically-constructed buffers. The undo list just chews up
> memory keeping track of our calls to insert.
Pushed.
d
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-24 12:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-21 1:00 [PATCH] emacs: Don't record undo information for search or show buffers Austin Clements
2011-11-21 1:07 ` Dmitry Kurochkin
2011-11-24 12:53 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).