From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 6/9] cli: change the data structure for notmuch address deduplication
Date: Thu, 24 Sep 2015 09:32:13 -0300 [thread overview]
Message-ID: <87fv242e2a.fsf@zancas.localnet> (raw)
In-Reply-To: <d8bb01aff648f9b73ec5f09f0e86e42dac2a21a6.1441308761.git.jani@nikula.org>
Jani Nikula <jani@nikula.org> writes:
> + else
> + v = !!m1->name - !!m2->name;
Is this really idiomatic? It seems a little difficult to follow to me.
> /* Returns TRUE iff name and addr is duplicate. If not, stores the
> * name/addr pair in order to detect subsequent duplicates. */
> static notmuch_bool_t
> is_duplicate (const search_context_t *ctx, const char *name, const char *addr)
> {
> char *key;
> + GList *list, *l;
> mailbox_t *mailbox;
>
> - key = talloc_asprintf (ctx->format, "%s <%s>", name, addr);
> - if (! key)
> - return FALSE;
> + list = g_hash_table_lookup (ctx->addresses, addr);
> + if (list) {
> + mailbox_t find = {
> + .name = name,
> + .addr = addr,
> + };
> +
> + l = g_list_find_custom (list, &find, mailbox_compare);
> + if (l) {
> + mailbox = l->data;
> + mailbox->count++;
> + return TRUE;
> + }
>
> - mailbox = g_hash_table_lookup (ctx->addresses, key);
> - if (mailbox) {
> - mailbox->count++;
> - talloc_free (key);
> - return TRUE;
> + mailbox = new_mailbox (ctx->format, name, addr);
> + if (! mailbox)
> + return FALSE;
> +
> + /*
> + * XXX: It would be more efficient to prepend to the list, but
> + * then we'd have to store the changed list head back to the
> + * hash table. This check is here just to avoid the compiler
> + * warning for unused result.
> + */
> + if (list != g_list_append (list, mailbox))
> + INTERNAL_ERROR ("appending to list changed list head\n");
> +
> + return FALSE;
> }
>
> + key = talloc_strdup (ctx->format, addr);
> + if (! key)
> + return FALSE;
> +
> mailbox = new_mailbox (ctx->format, name, addr);
> if (! mailbox)
> return FALSE;
>
> - g_hash_table_insert (ctx->addresses, key, mailbox);
> + list = g_list_append (NULL, mailbox);
> + if (! list)
> + return FALSE;
> +
> + g_hash_table_insert (ctx->addresses, key, list);
>
> return FALSE;
> }
> @@ -401,12 +445,21 @@ _talloc_free_for_g_hash (void *ptr)
> }
>
> static void
> -print_hash_value (unused (gpointer key), gpointer value, gpointer user_data)
> +_list_free_for_g_hash (void *ptr)
> +{
> + g_list_free_full (ptr, _talloc_free_for_g_hash);
> +}
> +
> +static void
> +print_list_value (void *mailbox, void *context)
> {
> - const mailbox_t *mailbox = value;
> - search_context_t *ctx = user_data;
> + print_mailbox (context, mailbox);
> +}
>
> - print_mailbox (ctx, mailbox);
> +static void
> +print_hash_value (unused (void *key), void *list, void *context)
> +{
> + g_list_foreach (list, print_list_value, context);
> }
>
> static int
> @@ -792,8 +845,9 @@ notmuch_address_command (notmuch_config_t *config, int argc, char *argv[])
> argc - opt_index, argv + opt_index))
> return EXIT_FAILURE;
>
> - ctx->addresses = g_hash_table_new_full (g_str_hash, g_str_equal,
> - _talloc_free_for_g_hash, _talloc_free_for_g_hash);
> + ctx->addresses = g_hash_table_new_full (strcase_hash, strcase_equal,
> + _talloc_free_for_g_hash,
> + _list_free_for_g_hash);
>
> ret = do_search_messages (ctx);
>
> --
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2015-09-24 12:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 19:39 [PATCH v2 0/9] cli: alternative address deduplication Jani Nikula
2015-09-03 19:39 ` [PATCH v2 1/9] cli: g_hash_table_lookup_extended is overkill Jani Nikula
2015-09-03 19:39 ` [PATCH v2 2/9] cli: abstract new mailbox creation Jani Nikula
2015-09-03 19:39 ` [PATCH v2 3/9] cli: add support for not deduplicating notmuch address results Jani Nikula
2015-09-04 18:35 ` [PATCH 3½/9] test: notmuch address --deduplicate=no tests Jani Nikula
2015-09-20 12:43 ` David Bremner
2015-09-23 18:56 ` Jani Nikula
2015-09-03 19:40 ` [PATCH v2 4/9] man: document notmuch address --deduplicate=(no|mailbox) option Jani Nikula
2015-09-20 12:45 ` David Bremner
2015-09-23 19:31 ` [PATCH] " Jani Nikula
2015-09-24 10:37 ` David Bremner
2015-09-03 19:40 ` [PATCH v2 5/9] util: move strcase_equal and strcase_hash to util Jani Nikula
2015-09-03 19:40 ` [PATCH v2 6/9] cli: change the data structure for notmuch address deduplication Jani Nikula
2015-09-24 12:32 ` David Bremner [this message]
2015-09-24 12:40 ` David Bremner
2015-09-24 19:55 ` Tomi Ollila
2015-09-24 18:34 ` Jani Nikula
2015-09-24 23:31 ` David Bremner
2015-09-25 16:48 ` [PATCH 6/9 v3 part 1/2] util: add strcmp_null, a strcmp that handles NULL parameters Jani Nikula
2015-09-25 16:48 ` [PATCH 6/9 v3 part 2/2] cli: change the data structure for notmuch address deduplication Jani Nikula
2015-09-03 19:40 ` [PATCH v2 7/9] cli: add support for deduplicating based on case insensitive address Jani Nikula
2015-09-04 18:38 ` [PATCH 7½/9] test: add notmuch address --deduplicate=(no|mailbox|address) tests Jani Nikula
2015-09-25 0:02 ` David Bremner
2015-09-25 17:08 ` [PATCH v2 " Jani Nikula
2015-09-03 19:40 ` [PATCH v2 8/9] man: document notmuch address --deduplicate=address option Jani Nikula
2015-09-03 19:40 ` [PATCH v2 9/9] cli: do not sort addresses on --output=count or --deduplicate=address Jani Nikula
2015-09-07 12:52 ` [PATCH v2 0/9] cli: alternative address deduplication David Bremner
2015-09-26 10:48 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv242e2a.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).