From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, Jani Nikula <jani@nikula.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 3½/9] test: notmuch address --deduplicate=no tests
Date: Sun, 20 Sep 2015 09:43:59 -0300 [thread overview]
Message-ID: <87a8shtg4w.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1441391716-17282-1-git-send-email-jani@nikula.org>
Jani Nikula <jani@nikula.org> writes:
> Test not using address deduplication. Incorporate some trivial output
> sorting tests here, as they seem to lack tests.
> ---
> test/T095-address.sh | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 70 insertions(+)
>
> diff --git a/test/T095-address.sh b/test/T095-address.sh
> index 8eecb2a6a7ba..f8d902cb3a5e 100755
> --- a/test/T095-address.sh
> +++ b/test/T095-address.sh
> @@ -145,4 +145,74 @@ cat <<EOF >EXPECTED
> EOF
> test_expect_equal_file OUTPUT EXPECTED
>
> +test_begin_subtest "--deduplicate=no --sort=oldest-first --output=sender"
> +notmuch address --deduplicate=no --sort=oldest-first --output=sender '*' >OUTPUT
> +cat <<EOF >EXPECTED
> +Mikhail Gusarov <dottedmag@dottedmag.net>
> +Mikhail Gusarov <dottedmag@dottedmag.net>
> +Carl Worth <cworth@cworth.org>
> +
> +test_begin_subtest "--deduplicate=no --sort=newest-first --output=sender --output=recipients"
> +notmuch address --deduplicate=no --sort=newest-first --output=sender --output=recipients path:foo/new >OUTPUT
> +cat <<EOF >EXPECTED
> +Mikhail Gusarov <dottedmag@dottedmag.net>
> +notmuch@notmuchmail.org
> +Mikhail Gusarov <dottedmag@dottedmag.net>
Two comments:
1) It's suprising that Mikail is first in both the newest-first and
oldest-first list. Is it easy to explain why?
2) the use of path: term is not mentioned in the description. Should it
be mentioned somehow?
d
next prev parent reply other threads:[~2015-09-20 14:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 19:39 [PATCH v2 0/9] cli: alternative address deduplication Jani Nikula
2015-09-03 19:39 ` [PATCH v2 1/9] cli: g_hash_table_lookup_extended is overkill Jani Nikula
2015-09-03 19:39 ` [PATCH v2 2/9] cli: abstract new mailbox creation Jani Nikula
2015-09-03 19:39 ` [PATCH v2 3/9] cli: add support for not deduplicating notmuch address results Jani Nikula
2015-09-04 18:35 ` [PATCH 3½/9] test: notmuch address --deduplicate=no tests Jani Nikula
2015-09-20 12:43 ` David Bremner [this message]
2015-09-23 18:56 ` Jani Nikula
2015-09-03 19:40 ` [PATCH v2 4/9] man: document notmuch address --deduplicate=(no|mailbox) option Jani Nikula
2015-09-20 12:45 ` David Bremner
2015-09-23 19:31 ` [PATCH] " Jani Nikula
2015-09-24 10:37 ` David Bremner
2015-09-03 19:40 ` [PATCH v2 5/9] util: move strcase_equal and strcase_hash to util Jani Nikula
2015-09-03 19:40 ` [PATCH v2 6/9] cli: change the data structure for notmuch address deduplication Jani Nikula
2015-09-24 12:32 ` David Bremner
2015-09-24 12:40 ` David Bremner
2015-09-24 19:55 ` Tomi Ollila
2015-09-24 18:34 ` Jani Nikula
2015-09-24 23:31 ` David Bremner
2015-09-25 16:48 ` [PATCH 6/9 v3 part 1/2] util: add strcmp_null, a strcmp that handles NULL parameters Jani Nikula
2015-09-25 16:48 ` [PATCH 6/9 v3 part 2/2] cli: change the data structure for notmuch address deduplication Jani Nikula
2015-09-03 19:40 ` [PATCH v2 7/9] cli: add support for deduplicating based on case insensitive address Jani Nikula
2015-09-04 18:38 ` [PATCH 7½/9] test: add notmuch address --deduplicate=(no|mailbox|address) tests Jani Nikula
2015-09-25 0:02 ` David Bremner
2015-09-25 17:08 ` [PATCH v2 " Jani Nikula
2015-09-03 19:40 ` [PATCH v2 8/9] man: document notmuch address --deduplicate=address option Jani Nikula
2015-09-03 19:40 ` [PATCH v2 9/9] cli: do not sort addresses on --output=count or --deduplicate=address Jani Nikula
2015-09-07 12:52 ` [PATCH v2 0/9] cli: alternative address deduplication David Bremner
2015-09-26 10:48 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8shtg4w.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).